Rule: pointless-reassignment
#878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
approved these changes
Jul 1, 2024
| } | ||
| ``` | ||
|
|
||
| This rule does not consider that a violation. |
There was a problem hiding this comment.
Suggested change
| This rule does not consider that a violation. | |
| This rule does not consider such examples violations. |
There was a problem hiding this comment.
I wonder what if I a had a rule like foo_bar_whizzz_bang_bar_foo_baz_v1_foo, and then reassigned it for readability, would this be good to ignore too?
There was a problem hiding this comment.
I'd say the issue then would be you naming a rule or var like that in the first place :D
| some m1 in sorted_group | ||
| some m2 in sorted_group | ||
| some loc in package_locations[m1][m2] | ||
| e := loc |
Also: - fix the one violation of this rule found in our code :P - add metadata annotations to a bunch of rules Fixes #867 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
pointless-reassignment
branch
from
7a2d95b to
07e4ad7
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Also: - fix the one violation of this rule found in our code :P - add metadata annotations to a bunch of rules Fixes StyraInc#867 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Fixes #867