Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: prefer-strings-count #948

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Rule: prefer-strings-count #948

merged 1 commit into from
Jul 30, 2024

Conversation

anderseknert
Copy link
Member

Fixes #940

@anderseknert anderseknert force-pushed the prefer-strings-count branch from 55bc9a6 to e6081a6 Compare July 30, 2024 07:11
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some comments on 'prefer' vs 'use'

@anderseknert anderseknert force-pushed the prefer-strings-count branch from e6081a6 to 803db1b Compare July 30, 2024 09:14
Fixes #940

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert force-pushed the prefer-strings-count branch from 803db1b to 417a2b0 Compare July 30, 2024 09:19
@anderseknert anderseknert merged commit 8a8b8ad into main Jul 30, 2024
3 checks passed
@anderseknert anderseknert deleted the prefer-strings-count branch July 30, 2024 09:23
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
Fixes StyraInc#940

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule: prefer-strings-count
2 participants