Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: Skip textDocument/completion for ignored files #953

Merged
merged 1 commit into from
Jul 30, 2024
Merged

lsp: Skip textDocument/completion for ignored files #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/lsp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,15 @@ func (l *LanguageServer) handleTextDocumentCompletion(
return nil, fmt.Errorf("failed to unmarshal params: %w", err)
}

// when config ignores a file, then we return an empty completion list
// as a no-op.
if l.ignoreURI(params.TextDocument.URI) {
return types.CompletionList{
IsIncomplete: false,
Items: []types.CompletionItem{},
}, nil
}

// items is allocated here so that the return value is always a non-nil CompletionList
items, err := l.completionsManager.Run(params, &providers.Options{
ClientIdentifier: l.clientIdentifier,
Expand Down