lsp/format,cmd/fix: Apply rego.v1 formatting by default #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to fixers to take fixes which will be run for all files, regardless of linter violations. This is intended to be useful for running using regal fix as an alternative to opa fmt where files will be rego-v1'd regarless of them containing import rego.v1. Signed-off-by: Charlie Egan <charlie@styra.com>
This means that the default fixes will all be applied on save unless disabled in config. With the exception of rego-v1, where this is always run. Signed-off-by: Charlie Egan <charlie@styra.com>
This means that all files will get the rego.v1 fix, regardless of the violation being found. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Aug 2, 2024
| // return "null" as per the spec | ||
| return nil, nil | ||
| li := linter.NewLinter(). | ||
| WithUserConfig(*l.loadedConfig). |
There was a problem hiding this comment.
This is a nil-dereference panic if no config is provided. I know because I did the same mistake on my branch 😆
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This adds support to fixers to take fixes which will be run for all files, regardless of linter violations. This is intended to be useful for running using regal fix as an alternative to opa fmt where files will be rego-v1'd regarless of them containing import rego.v1. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
rego.v1being imported.This is implemented by adding the concept of mandatory fixes, where these are run on all files even if there are no violations, before the linter based fixes are run.
LSP on save:
Untitled.mov
Fix cmd:
