Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bugs category, and two new rules #96

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add bugs category, and two new rules #96

merged 1 commit into from
Apr 26, 2023

Conversation

anderseknert
Copy link
Member

Two new linter rules in a new "bugs" category:

  • constant-conditions
  • top-level-iteration

I found that I also wanted a way to use print for nested objects, but the default serialization is really compact. Added a regal.json_pretty to help with that.

Two new linter rules in a new "bugs" category:

- constant-conditions
- top-level-iteration

I found that I also wanted a way to use `print` for nested
objects, but the default serialization is really compact.
Added a `regal.json_pretty` to help with that.

Signed-off-by: Anders Eknert <anders@styra.com>
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some day we're going to need to wire up these Styra docs links 😉

@anderseknert
Copy link
Member Author

Hehe, yes, or at least rewrite them to wherever the docs will be. Should be fairly easy to search-replace though!

@anderseknert anderseknert merged commit e917c1e into main Apr 26, 2023
@anderseknert anderseknert deleted the bugs branch April 26, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants