perf: Walk less #965
Merged
perf: Walk less #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
approved these changes
Aug 6, 2024
- Use `ast.found.refs` instead of `walk` in `use-some-for-output-vars` - Cheaper `walk` over `else` in `default-over-else` and `use-assignment-operator` - Remove some unnecessary code in `external-reference` The plan was also to consolidate `ast.found.symbols` with `ast.found.refs`, but that had disastrous consequences leading to something I think is a bug in OPA. I have demonstrated that to @charlieegan3, but will need to consult the OPA team once they're back from vacation. Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
- Use `ast.found.refs` instead of `walk` in `use-some-for-output-vars` - Cheaper `walk` over `else` in `default-over-else` and `use-assignment-operator` - Remove some unnecessary code in `external-reference` The plan was also to consolidate `ast.found.symbols` with `ast.found.refs`, but that had disastrous consequences leading to something I think is a bug in OPA. I have demonstrated that to @charlieegan3, but will need to consult the OPA team once they're back from vacation. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ast.found.refsinstead ofwalkinuse-some-for-output-varswalkoverelseindefault-over-elseanduse-assignment-operatorexternal-referenceThe plan was also to consolidate
ast.found.symbolswithast.found.refs, but that had disastrous consequences leading to something I think is a bug in OPA. I have demonstrated that to @charlieegan3, but will need to consult the OPA team once they're back from vacation.