lsp: Workspace eval, return rule head locations #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
rule-head-wip
branch
from
8271547 to
9edd7ba
Compare
anderseknert
approved these changes
Aug 13, 2024
bundle/regal/ast/rule_heads.rego
Outdated
| # description: | | ||
| # For a given rule head name, this rule contains a list of locations where | ||
| # there is a rule head with that name. | ||
| rule_heads[name] contains info if { |
There was a problem hiding this comment.
I'd probably call this rule_head_locations or something as the full rule head isn't in the set
|
|
||
| import data.regal.ast | ||
|
|
||
| test_rule_head_locations if { |
There was a problem hiding this comment.
oh, the test is even named as such :)
There was a problem hiding this comment.
Ha, it was that, then is was rule_heads, and now it's back again!
|
|
||
| result := ast.rule_heads with input as object.union( | ||
| regal.parse_module("p.rego", policy), | ||
| {"regal": {"file": {"lines": split(policy, "\n")}}}, |
There was a problem hiding this comment.
Interesting. I would have thought regal.parse_module included this
There was a problem hiding this comment.
This isn't actually needed for this test, so I have just dropped it and used the parse.
charlieegan3
force-pushed
the
rule-head-wip
branch
2 times, most recently
from
0b51831 to
2420d42
Compare
This allows for more reliable highlighting in the UI.
Correct rule_heads name, tidy rego test Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
rule-head-wip
branch
from
2420d42 to
38ed19c
Compare
Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* lsp: Workspace eval, return rule head locations This allows for more reliable highlighting in the UI. * Address PR comments Correct rule_heads name, tidy rego test Signed-off-by: Charlie Egan <charlie@styra.com> * lsp: Fix linter Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more reliable highlighting in the UI.
Needs: open-policy-agent/vscode-opa#241