Bugfix: Ensure blacklist expires_at is set in a fully UTC context #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found in a context where
UTC
was not the Django timezone, but ratherAsia/Tokyo
. I have added a test which replicates the issue.Before:
iat (UTC)
expires_at_unix_time = iat + 30mins (UTC)
expires_at = iat + 30mins (Asia/Tokyo) → this means the token is created already expired!
After:
iat (UTC)
expires_at_unix_time = iat + 30mins (UTC)
expires_at = iat + 30mins (UTC)