Download (stream) not raising events / closing file #344

fabricedupre · 2023-09-05T12:03:55Z

Hello,

Only event I receive is PropertyChanged with Duration.
I never get any PropertyChanged with DownloadPercentage or CurTime, or any DownloadCompleted.
And BTW, target file is created but not closed until I close the window.

SuRGeoNix · 2023-09-06T07:24:42Z

@fabricedupre I cannot help without seeing your code. Did you check the downloader sample which works fine?

fabricedupre · 2023-09-06T08:40:34Z

Here it is... Please note that Videostream is similar to the one I use (without issue) in Player.OpenAsync(Videostream);

    private async void mnuSave_Click(object sender, System.EventArgs e)
    {
        Config Config = new Config();
        Config.Demuxer.BufferDuration = 60 * 1000 * 10000;  // 60 seconds should be enough to allow max download speed
        Config.Demuxer.ReadTimeout = 60 * 1000 * 10000;     // 60 seconds to retry or fail
        Config.Video.MaxVerticalResolutionCustom = 1080;    // Default Plugins Suggest based on this

        Downloader Downloader = new Downloader(Config);

        Downloader.DownloadCompleted += (_sender, _e) =>
        {
            System.Diagnostics.Trace.WriteLine(!_e ? "Download Failed" : (Downloader.DownloadPercentage == 100 ? "Download Completed" : "Download Completed (Partial)"));
        };

        Downloader.PropertyChanged += (_sender, _e) =>
        {
            switch (_e.PropertyName)
            {
                case "Duration":
                case "CurTime":
                    System.Diagnostics.Trace.WriteLine($"{(new TimeSpan(Downloader.CurTime)).ToString(@"hh\:mm\:ss")}/{(new TimeSpan(Downloader.Duration).ToString(@"hh\:mm\:ss"))}");
                    break;
                case "DownloadPercentage":
                    System.Diagnostics.Trace.WriteLine($"{(int)Downloader.DownloadPercentage}%");
                    break;
            }
        };

        Downloader.Open(Videostream);

        SaveFileDialog sfd = new SaveFileDialog()
        {
            Filter = "Media files (*.avi)|*.avi|All files (*.*)|*.*",
            RestoreDirectory = true,
            FileName = "test.avi",
        };
        if (sfd.ShowDialog() != DialogResult.OK)
            return;

        string filename = sfd.FileName;
        Downloader.Download(ref filename, false);
    }
}

SuRGeoNix · 2023-09-06T08:56:29Z

What about logs? Do you see anything there? (What is the Videostream? oh the new System.IO.Stream you asked ok)
Update: Just tested and worked fine with System.IO.Stream

try to use this:-

string filename = "test1";
Downloader.Download(ref filename, true);

Does the Videostream contain valid media data? You will need to manually close it at the end.

fabricedupre · 2023-09-06T09:49:40Z

1- trying with
string filename = @"c:\test"; // sfd.FileName;
Downloader.Download(ref filename, true);
=> same

2- debug content
11.46.24.626 | Info | [FlyleafEngine] Audio Devices
{0.0.0.00000000}.{8031cf08-78bf-4b5d-9348-a19f9d5d68cf} | U28D590 (NVIDIA High Definition Audio)
{0.0.0.00000000}.{85430695-fcd9-486d-a25e-1dd65a406d0a} | Headphone (Plantronics Savi 8200 Office Series) *
{0.0.0.00000000}.{a5442a95-9990-4208-88b5-e5202c9bf058} | U32J59x (NVIDIA High Definition Audio)
{0.0.0.00000000}.{cfcd250a-e33b-4cd7-a6cb-60ea062a665e} | Speakers (Realtek(R) Audio)
{0.0.0.00000000}.{d345656a-a47e-4826-b872-183ab1ed54e2} | Headphones (Realtek(R) Audio)

11.46.24.650 | Info | [FlyleafEngine] FlyleafLib 3.7.22
11.46.24.744 | Info | [FlyleafEngine] Loading FFmpeg libraries from ':FFmpeg'
11.46.25.233 | Info | [FlyleafEngine] FFmpeg Loaded (Location: C:\PE\Dev CY\CYManager\FFmpeg, Ver: 59.27.100) [Devices: no, Filters: yes]
11.46.25.354 | Info | [FlyleafEngine] GPU Adapters
[#1] Intel Intel(R) UHD Graphics [ID: 18056 , LUID: 149847, DVM: 128 MB , DSM: 0 B , SSM: 31.8 GB]
[#2] NVIDIA NVIDIA RTX A3000 12GB Laptop GPU [ID: 9401 , LUID: 151759, DVM: 11.85 GB, DSM: 0 B , SSM: 31.8 GB]
[#3] Unknown Microsoft Basic Render Driver [ID: 140 , LUID: 151705, DVM: 0 B , DSM: 0 B , SSM: 31.8 GB]

3- I can only close the stream when I get the DownloadCompleted event :-)

SuRGeoNix · 2023-09-06T10:21:14Z

For some reason it seems that it does not open/add the stream(s).

Try this, before Downloader.Download:-

Downloader.DecCtx.VideoDemuxer.EnableStream(Downloader.DecCtx.VideoDemuxer.VideoStreams[0]);

fabricedupre · 2023-09-06T10:30:22Z

Not any better:
12.28.19.075 | Info | [FlyleafEngine] Audio Devices
{0.0.0.00000000}.{8031cf08-78bf-4b5d-9348-a19f9d5d68cf} | U28D590 (NVIDIA High Definition Audio)
{0.0.0.00000000}.{85430695-fcd9-486d-a25e-1dd65a406d0a} | Headphone (Plantronics Savi 8200 Office Series) *
{0.0.0.00000000}.{a5442a95-9990-4208-88b5-e5202c9bf058} | U32J59x (NVIDIA High Definition Audio)
{0.0.0.00000000}.{cfcd250a-e33b-4cd7-a6cb-60ea062a665e} | Speakers (Realtek(R) Audio)
{0.0.0.00000000}.{d345656a-a47e-4826-b872-183ab1ed54e2} | Headphones (Realtek(R) Audio)

12.28.19.133 | Info | [FlyleafEngine] FlyleafLib 3.7.22
12.28.19.154 | Info | [FlyleafEngine] Loading FFmpeg libraries from ':FFmpeg'
12.28.19.250 | Info | [FlyleafEngine] FFmpeg Loaded (Location: C:\PE\Dev CY\CYManager\FFmpeg, Ver: 59.27.100) [Devices: no, Filters: yes]
12.28.19.310 | Info | [FlyleafEngine] GPU Adapters
[#1] Intel Intel(R) UHD Graphics [ID: 18056 , LUID: 149847, DVM: 128 MB , DSM: 0 B , SSM: 31.8 GB]
[#2] NVIDIA NVIDIA RTX A3000 12GB Laptop GPU [ID: 9401 , LUID: 151759, DVM: 11.85 GB, DSM: 0 B , SSM: 31.8 GB]
[#3] Unknown Microsoft Basic Render Driver [ID: 140 , LUID: 151705, DVM: 0 B , DSM: 0 B , SSM: 31.8 GB]

12.29.22.008 | Debug | [#1] [Demuxer: Main] Opening -> Stopped

fabricedupre · 2023-09-06T10:31:15Z

Forgot to mention that file is created and video properly exported, only events are not raised

SuRGeoNix · 2023-09-06T10:32:20Z

The problem seems to be the bgr0 which is raw format (this is not an avi). The downloader currently works only with proper formats (no raw data) as it will require to transcode/transmux which is not currently implemented.

fabricedupre · 2023-09-06T10:40:12Z

But file is properly generated, only it is not properly closed and no event is sent.
That's weird !? Any workaround until transcode/transmux is implemented ?

SuRGeoNix · 2023-09-06T10:42:57Z

The file that it creates is just the file with the headers and not the data as it does not enable any stream and does not write any packets. Unfortunately there is no workaround for that, input format should be able to transmux to output format (so codecs should be supported by the output format). Maybe you could try with .raw extension or check FFmpeg which format supports bgr0 (if any). Still not sure why you don't see any errors though.

You should also see that the demuxer opens the video stream (0) ... you will need to debug it. Maybe something else is the issue.

fabricedupre · 2023-09-06T10:47:18Z

Then, how can it be that I can play the file properly ?

SuRGeoNix · 2023-09-06T10:47:58Z

which file, the output file? Can you give me anydesk access to debug it quickly? :) Try trace log

fabricedupre · 2023-09-06T13:18:26Z

Couple things:
a/ I cannot play the file anymore (I can swear I could before)
b/ I am using NuGet package so can not debug, will switch to local version
c/ not sure anydesk will pass the firewall
d/ video is using SCPR codec

SuRGeoNix · 2023-09-06T13:29:42Z

@fabricedupre No worries, probably is the reason that I've mention already. But if you want to debug it you could download the code from here and include FlyleafLib project to your solution and instead of pointing the NuGet you can point the project.

fabricedupre · 2023-09-06T15:34:48Z

Here is what I managed to achieve by breaking on Downloader.cs line 307 and pressing F5 couple times:
00:01:00/00:10:02
10%
00:01:35/00:10:02
15%
00:01:35/00:10:02
15%
00:01:35/00:10:02
15%
00:01:36/00:10:02
15%
00:01:36/00:10:02
16%
00:01:37/00:10:02
16%
00:01:38/00:10:02
16%
00:01:38/00:10:02
16%
00:01:39/00:10:02
16%
00:01:40/00:10:02
16%
00:01:41/00:10:02
16%
00:01:42/00:10:02
17%
00:01:43/00:10:02
17%
00:01:44/00:10:02
17%
00:01:46/00:10:02
17%
00:01:47/00:10:02
17%
00:01:48/00:10:02
18%
00:01:49/00:10:02
18%
00:01:51/00:10:02
18%
00:01:52/00:10:02
18%
00:01:53/00:10:02
18%
00:01:54/00:10:02
19%
00:01:55/00:10:02
19%
00:01:57/00:10:02
19%
00:01:58/00:10:02
19%
00:01:59/00:10:02
19%
00:02:00/00:10:02
20%
00:02:01/00:10:02
20%
00:02:03/00:10:02
20%
00:02:04/00:10:02
etc...

As soon as I remove the breakpoint on line 307 and set it on line 309... nothing happens anymore !
Getting the below output:
The thread '.NET ThreadPool Worker' (0x2ae0) has exited with code 0 (0x0).
The thread '.NET ThreadPool Worker' (0x10158) has exited with code 0 (0x0).
The thread '.NET ThreadPool Worker' (0xf90c) has exited with code 0 (0x0).
The thread '.NET ThreadPool Worker' (0x168e0) has exited with code 0 (0x0).

And log file:
log.txt

SuRGeoNix · 2023-09-06T16:20:01Z

sry @fabricedupre, that does not really help

fabricedupre · 2023-09-06T17:34:56Z

In fact, once Demuxer.Packets.Count == 0, the while loop at line 207 never ends
By forcing Demuxer.Status = Status.Ended, aka going to line 211, everything works !
File created, closed and playable.
Now the question is why is Demuxer not entering Status.Ended state ?

SuRGeoNix · 2023-09-06T17:52:14Z

Check the threads (and mainly the Demuxer) when it freezes to see why the demuxer waits

SuRGeoNix · 2023-09-06T20:45:22Z

@fabricedupre Just had another look, trying to guess your issue... Try to replace in this line the AVERROR_EXIT with AVERROR_EOF

Update: Actually more important change the < 0 to <= 0 (I will do more testing tomorrow as I think that this is indeed an issue with the custom IO streams)

fabricedupre · 2023-09-07T05:57:33Z

Same behavior :-(
What is the purpose of #if NETFRAMEWORK ? Actually it is not defined...

…tical flipping CustomIOContext: Fixes a critical issue with the EOF (read bytes = 0) which could cause the demuxer to freeze (Fixes #344)

SuRGeoNix · 2023-09-07T14:39:02Z

@fabricedupre it should be fixed with master now, I was able to find a SCPR sample and reproduce the issue. Found also another one with negative linesizes which could crash the player. If you can't tested from master I will have soon an update NuGet package.

fabricedupre · 2023-09-07T16:24:37Z

Great !
Works like a charm (both Master / NuGet pkg)
Do you have any plan/timeframe when you gonna release transcode/transmux ?

SuRGeoNix · 2023-09-07T16:30:10Z

I've some progress with FlyleafLib v4 which will support those but to be honest I was planning it by the end of the year, not sure if I will manage this.

fabricedupre · 2023-09-07T16:33:22Z

Good luck !

SuRGeoNix closed this as completed Sep 6, 2023

Repository owner deleted a comment from fabricedupre Sep 6, 2023

SuRGeoNix added a commit that referenced this issue Sep 7, 2023

Renderer: Fixes an issue when linesize is negative which requires ver…

fb03b59

…tical flipping CustomIOContext: Fixes a critical issue with the EOF (read bytes = 0) which could cause the demuxer to freeze (Fixes #344)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download (stream) not raising events / closing file #344

Download (stream) not raising events / closing file #344

fabricedupre commented Sep 5, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 6, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 7, 2023

SuRGeoNix commented Sep 7, 2023

fabricedupre commented Sep 7, 2023

SuRGeoNix commented Sep 7, 2023

fabricedupre commented Sep 7, 2023

Download (stream) not raising events / closing file #344

Download (stream) not raising events / closing file #344

Comments

fabricedupre commented Sep 5, 2023 • edited Loading

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 • edited Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 • edited Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 • edited Loading

fabricedupre commented Sep 6, 2023 • edited Loading

SuRGeoNix commented Sep 6, 2023 • edited Loading

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

fabricedupre commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023

SuRGeoNix commented Sep 6, 2023 • edited Loading

fabricedupre commented Sep 7, 2023

SuRGeoNix commented Sep 7, 2023

fabricedupre commented Sep 7, 2023

SuRGeoNix commented Sep 7, 2023

fabricedupre commented Sep 7, 2023

fabricedupre commented Sep 5, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

fabricedupre commented Sep 6, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading

SuRGeoNix commented Sep 6, 2023 •

edited

Loading