Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug:when returning from fullscreen to normalscreen,missing surface.border.background #498

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

LazyCuteLion
Copy link
Contributor

fix bug:when returning from fullscreen to normalscreen, the CornerRadius background has issue it's like a mask color (when play alpha video)

…ius background has issue it's like a mask color (when play aplha video)
@SuRGeoNix SuRGeoNix merged commit d4ac51b into SuRGeoNix:master Sep 27, 2024
@SuRGeoNix
Copy link
Owner

That was causing issues so I revert it (eg with normal/fullscreen on sample project)

@LazyCuteLion
Copy link
Contributor Author

LazyCuteLion commented Oct 14, 2024

That was causing issues so I revert it (eg with normal/fullscreen on sample project)

oh,i tested it again,the problem is : 1、open fullscreen 2、return to normalscreen 3、open fullscrenn again(yes, the location to right-bottom)

but when play with alpha video,there has some issues with background if revert this commit.
can you try this:
#492
https://github.com/LazyCuteLion/Flyleaf/tree/alpha_video

@LazyCuteLion
Copy link
Contributor Author

LazyCuteLion commented Oct 14, 2024

i test FlyleafPlayer (Custom - MVVM) (WPF),it is ok!
FlyleafHost use standAlone has this issues.

@SuRGeoNix
Copy link
Owner

@LazyCuteLion you suggest adding this only in case of non-standalone mode?

@LazyCuteLion
Copy link
Contributor Author

LazyCuteLion commented Oct 15, 2024

yes,i push a new commit,but i don't know if should create a merge? can you check this? (it is a way to work well with play alpha video,and fix this bug. i tested it many times,it seems to be ok)
LazyCuteLion@86596a7

@LazyCuteLion
Copy link
Contributor Author

nothing but,if not play with alpha video,this issues is no issues.
i'm not sure about the changes to the files(renderer and sharder) has any other effect,although everything seems well so far.

@SuRGeoNix
Copy link
Owner

I've included the fix for normal/fullscreen however we should review the alpha support separately.

@LazyCuteLion
Copy link
Contributor Author

the branch of alpha_video only support wpf,winui3 get nowhere.
thank you very much for your precious time. @SuRGeoNix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants