Nullsafety and merge chewie 1.0.0 #12
Conversation
Export controls in chewie.dart.
Since fluttercommunity@971c97a, chewie won't compile with Flutter version lower than 1.22. See flutter/flutter@2032a44 for more information. This commit bumps the required version in `pubspec.yaml` so app developers can upgrade their Flutter installation.
Bump required Flutter version 1.20 -> 1.22
The flutter action gets the newest package. Better since image is not updated instantly on new release. Run time is probably even better.
IOS simulator now works on flutter 1.26.0.
* Jeremiah-Parrack | [Chore] Fix lint * Jeremiah-Parrack | remove autogenerated line in Debug.xcconfig * Jeremiah-Parrack | remove autogenerated line in Release.xcconfig Co-authored-by: Jeremiah-Parrack <jeremiah.parrack@coxautoinc.com>
|
Looks decent on first glance. Indeed in some cases it looks like force unwrapping could be reduced, but I'd have to look into detail in that. |
Migrate to null safety
Merge the Material and Cupertino progress bars
Animate all play/pause icons
Hey @erickok |
|
@erickok now I'm using chewies nullsafety migration in this PR and thus have merged the changes. I removed all the video related things so the experience should be very similar to before. The merge also fixes some issues noted in OP. |
|
Thanks so much for this work @tneotia - it is a pretty big task. I have tested your changes (against Flutter 2.0.1) and it is generally working well. I am going to merge. |
|
Actually I don't have the right to merge. @ryan-berger has to do this. |
| @@ -9,20 +9,19 @@ authors: | |||
| - Eric Kok <erickok@gmail.com> | |||
|
|
|||
There was a problem hiding this comment.
Can you bump the version here to 1.2.0 as well? Then all we need for a release is to merge this PR.
|
@ryan-berger could you please merge this? Then I will release. |
|
Hey @erickok any estimates on when that release is going to happen? Thanks so much for all the work here guys! |
|
It's release as 1.2.0. Thanks again @tneotia - all credits to you. And thanks to @ryan-berger for merging. |
I let the migration tool decide everything for this one - I tried to force some changes with
lateto reduce the number of!but they didn't work.Fixes #3 and possibly #1? Don't know for sure.