Skip to content

Line height (TextStyle.height) #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mileusna opened this issue Mar 1, 2020 · 11 comments
Closed

Line height (TextStyle.height) #233

mileusna opened this issue Mar 1, 2020 · 11 comments

Comments

@mileusna
Copy link

mileusna commented Mar 1, 2020

I'm using 1.0.0-pre1

It would be nice to have Style.lineHeight property or similar, which would be used as TextStyle.height in TextStyle class.

https://api.flutter.dev/flutter/painting/TextStyle/height.html

@Sub6Resources
Copy link
Owner

Yes, this is a planned feature in 1.0.0. Thank you for your suggestion!

@josearagon
Copy link

We are looking forward to that new upload. We need line-height and text-align please.

Thanks a lot!

@red42
Copy link

red42 commented May 13, 2020

Hi, thanks for the update, 1.0.0 looks great. I can't seem to find lineHeight on the Style class, however. I tried using height, but that seems to be the height of the entire Html widget, and not each line of text. I may be missing something.

@krokyze
Copy link

krokyze commented May 15, 2020

Is lineHeight available in 1.0.0?

@sayhicoelho
Copy link

+1 for lineHeight

@vanlooverenkoen
Copy link
Contributor

I have created a PR for this: #306

you can find my branch here while waiting for the approval
https://github.com/vanlooverenkoen/flutter_html/tree/feature/%23233-line-height-support

@penniath
Copy link

IMHO this is a key feature to have.
The PR created by @vanlooverenkoen will just make it.

Do you think this will be available any time soon?

Thanks!

@kassanj
Copy link

kassanj commented Jul 22, 2020

What's the status on this feature request?

@vanlooverenkoen
Copy link
Contributor

vanlooverenkoen commented Jul 23, 2020

I have implemented it. But the maintainer of this package is not really active. #233 (comment)

@fahmisatrio
Copy link

+1 for @vanlooverenkoen PR
it's great addition.

thanks @vanlooverenkoen !

ryan-berger added a commit that referenced this issue Sep 5, 2020
@erickok
Copy link
Contributor

erickok commented Feb 8, 2021

Duplicate of #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests