Skip to content

Chewie dependency to old. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maerlynflagg opened this issue Nov 16, 2020 · 10 comments · Fixed by #455
Closed

Chewie dependency to old. #452

maerlynflagg opened this issue Nov 16, 2020 · 10 comments · Fixed by #455

Comments

@maerlynflagg
Copy link

Because no versions of flutter_html match >1.0.2 <2.0.0 and flutter_html 1.0.2 depends on chewie ^0.9.10, flutter_html ^1.0.2 requires chewie ^0.9.10.

Because chewie 0.9.10 depends on wakelock ^0.1.2 and no versions of chewie match >0.9.10 <0.10.0, chewie ^0.9.10 requires wakelock ^0.1.2.

chewie is since version 0.11.0 upgraded to the actual wakelock version:
https://pub.dev/packages/chewie/changelog

Please upgrade chewie, if you can.

@diegoalex
Copy link

Same issue here.
I have to update the video player and chewie packages but it stops because flutter_html dependency doesn't match.

@vurcease
Copy link

Adding my vote to the pile.

Our app is using flutter_html for a couple web views and now we are blocked from submitting to the Apple App Store due to the known open-iconic font issue with the older version of the dependency.

It would seem that any Flutter app using this cannot currently gain App Store approval until the chewie dependency is updated to 0.10.2 or later.

@erickok
Copy link
Contributor

erickok commented Nov 17, 2020

Yes, flutter_html needs to update. But you can force any package from your own pubspec so unless you need a combination that is incompatible (which I believe is not the case), you can still build a working app and upload it to Apple. (We do at my project.)

@maerlynflagg
Copy link
Author

currently i'm using the override function for this:

dependency_overrides:
  wakelock: ^0.2.1

but i think, chewie can be updated in flutter_html directly. it's better.

@vurcease
Copy link

currently i'm using the override function for this:

dependency_overrides:
  wakelock: ^0.2.1

but i think, chewie can be updated in flutter_html directly. it's better.

How did you get around chewie_audio's dependency?

I was able to use @erickok 's suggestion to over ride the chewie dependency - thanks! But now I'm stuck on the chewie_audio dependency which doesn't yet have a release version that doesn't itself depend on the open-iconic font package.

@erickok
Copy link
Contributor

erickok commented Nov 17, 2020

Hmm I didn't know about chewie_audio. I'll see if I can make a PR there too to remove the iconic font, as I did for chewie video.

@erickok
Copy link
Contributor

erickok commented Nov 19, 2020

I created a PR for chewie_audio at Sub6Resources/chewie_audio#8

Now, since this project is owned by Sub6Resources and he is pretty much inactive, I am unsure how likely this is to be merged. But you can of course use the git hash to point to this version specifically.

@vurcease
Copy link

vurcease commented Nov 19, 2020

I created a PR for chewie_audio at Sub6Resources/chewie_audio#8

Now, since this project is owned by Sub6Resources and he is pretty much inactive, I am unsure how likely this is to be merged. But you can of course use the git hash to point to this version specifically.

Thank you, your time and effort are very appreciated - truly. We'll make any temp adjustments in our project and keep an eye on this. Cheers!

erickok added a commit to vrtdev/flutter_html that referenced this issue Nov 19, 2020
…rsions

As this upgrade wakelock and that is supporting Flutter's v2 binding on Android only, I upgrade the example project to use that
@EHBradford
Copy link

I am very confused by this problem. I cannot determine based upon this discussion a valid course of action. My project has been down for 2+ weeks due to what looks like a "Chewie" dependency??????

Can anyone please help me get through a valid build by providing a working set of pubspec.yaml entries?

I am at my wits end trying to determine which libraries to include and their corresponding versions.

@erickok
Copy link
Contributor

erickok commented Jan 30, 2021

@EHBradford I think you are experiencing #487 instead of this? Because this issue is solved months ago already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants