-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lists and upgrade List support to CSS3 #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super work!
I will run on some examples, but the code looks solid.
Codecov ReportBase: 49.70% // Head: 51.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
+ Coverage 49.70% 51.41% +1.71%
==========================================
Files 18 19 +1
Lines 2682 2641 -41
==========================================
+ Hits 1333 1358 +25
+ Misses 1349 1283 -66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@erickok If you wouldn't mind doing a quick rereview on the most recent commit (which re-adds basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The new
CssBoxWidget
allows us to effectively render a "marker box" on elements, especially list elements. This upgrade fixes almost all of our open list issues. It removes support for custom Widget list markers, since CSS doesn't support that (however, the same functionality could easily be re-added in aCustomRender
by interested parties).This pull request also removes the roman-numeral-specific
numerus
dependency in favor of the more generallist_counter
dependency (disclosure: package written by myself). This change in dependency allows us to expand our list style support to 54 different list-styles, including dozens of new languages.This pull request fixes the following open and tightly-related issues:
Fixes #1100
Fixes #245
Fixes #984
Fixes #991
Fixes #1016
Fixes #1020
Fixes #1104
This pull request is
a work in progressready to go. Still to do: