Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vertical-align in inline styles #1266

Merged
merged 2 commits into from
May 15, 2023

Conversation

Sub6Resources
Copy link
Owner

Fixes #1107

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 89.65% and project coverage change: +0.57 🎉

Comparison is base (d7247cb) 58.62% compared to head (cd8381c) 59.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   58.62%   59.20%   +0.57%     
==========================================
  Files          37       37              
  Lines        2642     2652      +10     
==========================================
+ Hits         1549     1570      +21     
+ Misses       1093     1082      -11     
Impacted Files Coverage Δ
lib/src/css_parser.dart 16.19% <72.72%> (+2.11%) ⬆️
lib/src/style.dart 84.80% <100.00%> (-0.08%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sub6Resources Sub6Resources merged commit fe896de into master May 15, 2023
@Sub6Resources Sub6Resources deleted the fix/css-vertical-align branch May 15, 2023 18:09
Luca-CZ added a commit to CZ-App/flutter_html_lite that referenced this pull request Nov 11, 2024
…rsion

 - **FIX**: start list items on a new line ([Sub6Resources#1281](Sub6Resources#1281)). ([496d1aa](Sub6Resources@496d1aa))
 - **FIX**: Add "display: Display.block" to table ([Sub6Resources#1278](Sub6Resources#1278)). ([6350f02](Sub6Resources@6350f02))
 - **FIX**: improve API for ExtensionContext and export marker.dart ([Sub6Resources#1273](Sub6Resources#1273)). ([27e33a9](Sub6Resources@27e33a9))
 - **FIX**: Cleaned up whitespace processing and added whitespace tests ([Sub6Resources#1267](Sub6Resources#1267)). ([cc00406](Sub6Resources@cc00406))
 - **FIX**: a tag should not style as link if href is not provided ([Sub6Resources#1265](Sub6Resources#1265)). ([d7247cb](Sub6Resources@d7247cb))
 - **FEAT**: Update CssBoxWidget to handle rtl marker boxes ([Sub6Resources#1270](Sub6Resources#1270)). ([d709199](Sub6Resources@d709199))
 - **FEAT**: support vertical-align in inline styles ([Sub6Resources#1266](Sub6Resources#1266)). ([fe896de](Sub6Resources@fe896de))
 - **FEAT**: Add WrapperExtension helper ([Sub6Resources#1264](Sub6Resources#1264)). ([2ffa1dd](Sub6Resources@2ffa1dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vertical-align not working in Html/SelectableHtml
1 participant