Pass correct context to replaced element #886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other element renderers are passed
newContext
as theirRenderContext
- the context which has the appropriate styles for the element applied. However,ReplacedElement
seemed to miss this change, meaning things likeimg
tags did not get custom styles.For example, without this change, an element like this:
With an appropriate Container wrapping the network image:
Would render as:
![image](https://user-images.githubusercontent.com/9100419/140671924-640f6a6d-b0a5-49ab-9b1a-d6cf56282456.png)
With this change it can be rendered as expected: