Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the SwerveUtils header #13

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Implement the SwerveUtils header #13

merged 4 commits into from
Jul 28, 2024

Conversation

WowMuchDoge
Copy link
Contributor

@WowMuchDoge WowMuchDoge commented Jul 28, 2024 •
edited
Loading

Description of pull request

This PR

  • Implements the swerve utils header file

Closes #12

Before you merge

  • Compiles
  • Unit tests pass
  • Tested on the robot
  • Reviewed by another member

having11
having11 requested changes Jul 28, 2024
View reviewed changes
lib/cpp/subzero/drivetrain/SwerveUtils.cpp Outdated Show resolved Hide resolved
lib/cpp/subzero/drivetrain/SwerveUtils.cpp Outdated Show resolved Hide resolved
lib/cpp/subzero/drivetrain/SwerveUtils.cpp Outdated Show resolved Hide resolved
lib/cpp/subzero/drivetrain/SwerveUtils.cpp Outdated Show resolved Hide resolved
lib/cpp/subzero/drivetrain/SwerveUtils.cpp Outdated Show resolved Hide resolved
@having11 having11 self-requested a review July 28, 2024 18:10
having11
having11 approved these changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@having11 having11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but make sure to re-test in sim before this gets merged

@having11 having11 merged commit 4c7c4c0 into main Jul 28, 2024
2 checks passed
@having11 having11 deleted the feature/swerve-utils-implementation branch July 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@having11 having11 having11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an implementation for the SwerveUtils.h file
3 participants
@WowMuchDoge @having11 @lint-action