Next #32
Merged
Next #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the package is, within Sublime Text and Package Control, now consistently named Twig. - add manual installation instruction (with correct name/dir) - completions will change in upcoming changes, removed that from readme
no longer start with "t", so you can simply type, e.g. "if" and hit tab to insert the snippet - snippets are now presented as completions if you partially typed one - add a few missing tags
this package doesn't have files large enough to worry about ignoring
and renamed them to remove the package name prefix
ensuring we cover all documented structures
based on new and more detailed tests, covering all documented twig expressions at twig.symfony.com mainly with the goal of adding detail, e.g.: - to provide _filter_ completions where filters may be used - provide _test_ completions where tests may be used (ie. after "is") - improved recognition of various keywords and operators - recognize built-in functions, filters, etc but also fully support custom versions - handle filters that may take (optiona) arguments - recognize where variables are declared to support goto definition additionally: always clear scopes when embedded to ensure the twig expression itself is highlighted without the parent context interfering (ie. not just inside strings)
add test againt 4107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ }} as meta.expression.
ensuring clean highlighting of Twig statement not matter where it's inserted.
also fixes #28