Remove cruft #38

kaste · 2016-05-10T20:03:37Z

Never use builtin python 3.3 for linting Fixes invalid syntax on async keyword #33
Make show-code actually work Fixes show-code option is not working #35
Add option executable so you can point explicitly to a flake8 installation in case SL isn't smart enough (which it isn't on Windows)

Fixes #34, fixes #36

kaste · 2016-05-10T20:09:44Z

linter.py

@@ -56,83 +54,11 @@ class Flake8(PythonLinter):
        '--max-line-length=': None,
        '--max-complexity=': -1,
        '--jobs=': '1',
-        '--show-code=': False
+        'show-code': False,


That's essentially the thing to fix #35. Double '--' means that this is an argument for flake8, but we want it to be an internal argument for the linter.

kaste · 2016-05-10T20:17:02Z

Well, can you make the linter happy?

kaste · 2016-05-10T20:21:52Z

🎆

Gr1N · 2016-05-10T20:25:38Z

Really nice patch! So fix build and merge to master :)

kaste · 2016-05-10T21:22:19Z

Ok, what's going on here with travis? @groteworld

jacobsvante · 2016-05-11T11:43:34Z

Yippie! Can't wait for a new release with this! 🎊 🍻 🎉

numberoverzero · 2016-05-14T00:01:58Z

linter.py



 class Flake8(PythonLinter):
-
+    


This is the only line causing the travis failure:

The command "flake8 . --max-line-length=120" exited with 1. $ pep257 . --ignore=D202 ./linter.py:16 in public class `Flake8`: D211: No blank lines allowed before class docstring (found 1)

Can you remove this so the build passes? I'd love to see this merged 👍

I actually either get a D211: No blank lines allowed before class docstring (found 1) https://travis-ci.org/SublimeLinter/SublimeLinter-flake8/builds/129267208 or a D203: 1 blank line required before class docstring (found 0) https://travis-ci.org/SublimeLinter/SublimeLinter-flake8/builds/129247772

kaste · 2016-05-14T11:11:34Z

Ah, referring to PyCQA/pydocstyle#141 we loose the default ignore D203 as soon as we pass our own ignore info to pep257.

kaste · 2016-05-14T11:38:21Z

linter.py

@@ -148,35 +74,17 @@ def split_match(self, match):
        if near:
            col = None

-        if self.show_code:
+        if self.get_view_settings().get('show-code'):


get_view_settings should be enough

kaste · 2016-05-14T11:38:50Z

Okay, we're green. 🙌

jacobsvante · 2016-05-17T07:49:04Z

😀

FichteFoll · 2016-05-25T01:50:20Z

Again, referring to PyCQA/pydocstyle#141, you should be using the add-ignore option, which SublimeLinter-pydocstyle (name change) now properly supports:
SublimeLinter/SublimeLinter-pydocstyle#11 (SublimeLinter/SublimeLinter-pydocstyle@b17b4cd and SublimeLinter/SublimeLinter-pydocstyle@6329c42).

Edit: Actually, this has already been changed upstream an is the cause for the merge conflict.

Anyway, please merge this. I'm struck by #33 too and implemented the changes manually in an override package for now.

* Never use builtin python 3.3 for linting Fixes SublimeLinter#33 * Make `show-code` actually work Fixes SublimeLinter#35 * Add option `executable` so you can point explicitly to a flake8 installation in case SL's which isn't smart enough (which it isn't on Windows)

kaste · 2016-05-25T11:07:13Z

Rebased!

kaste · 2016-05-25T11:11:16Z

Does anybody know the/one of the maintainer(s)? B/c from my experience it is either you get a response relatively quickly or never. And after two weeks we're heading towards never.

Gr1N · 2016-05-25T11:15:59Z

@groteworld can you help with this pr?

FichteFoll · 2016-06-12T01:12:11Z

push

This plugin is unusable for Python 3.5 code without this PR.

EmilStenstrom · 2016-06-12T12:21:27Z

Great fix! 🎊 Will my local version of SublimeLinter-flake8 be updated automatically or does there have to be a release?

FichteFoll · 2016-06-12T22:01:26Z

There already is a release. Package control will update it automatically on the next st restart.

Gr1N · 2016-06-13T08:34:20Z

Guys, something goes wrong after update.
Sublime console:

SublimeLinter: WARNING: no flake8 version could be extracted from:
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 7, in <module>
    from flake8.main import main
ImportError: No module named flake8.main```

And my flake8 version and path:

~
➔ flake8 --version
2.5.4 (pep8: 1.7.0, pyflakes: 1.2.3, mccabe: 0.4.0) CPython 3.5.1 on Darwin

~
➔ which flake8
/usr/local/bin/flake8

Any ideas?

EmilStenstrom · 2016-06-13T08:45:44Z

I get the same error as @Gr1N, I think the offending row is the debug line just above what was posted:

SublimeLinter: flake8 version query: /usr/local/bin/python /virtualenvs/projectX/bin/flake8 --version 
SublimeLinter: WARNING: no flake8 version could be extracted from:
Traceback (most recent call last):
  File "/virtualenvs/projectX/bin/flake8", line 7, in <module>
    from flake8.main import main
ImportError: No module named flake8.main

Note the prefix "/usr/local/bin/python". Doing the same call in the terminal reproduces it:

~ $ /usr/local/bin/python /virtualenvs/projectX/bin/flake8 --version 
Traceback (most recent call last):
  File "/virtualenvs/projectX/bin/flake8", line 7, in <module>
    from flake8.main import main
ImportError: No module named flake8.main

Removing the python executable works fine:

~ $ /virtualenvs/projectX/bin/flake8 --version 
2.5.4 (pep8: 1.7.0, pyflakes: 1.0.0, mccabe: 0.4.0) CPython 3.4.1 on Darwin

kaste · 2016-06-13T09:08:02Z

Damn it. Works for me.

kaste · 2016-06-13T09:10:49Z

Can you post your configuration. On my system I have python 2.7 and 3.5, mostly everything in virtualenvs. And it just works. Default python is 2.7, and a globally installed flake8.

EDIT: I noticed that the version query always goes to the default python, global flake8 installation, maybe that's not good.

Gr1N · 2016-06-13T09:16:02Z

I have python 2.7 (default) and 3.5 and I use virtualenvs too, but flake8 installed globally using pip3. /usr/local/bin/python — python 2.7 in my system without flake8. Maybe python executable should be configurable through settings?

More logs:

SublimeLinter: find_posix_python: python3 => /usr/local/bin/python3 
SublimeLinter: find_python: system python = /usr/local/bin/python3 
SublimeLinter: find_python: available version = {'minor': 5, 'major': 3} 
SublimeLinter: find_python: <= ('/usr/local/bin/python3', None, 3, 5) 
SublimeLinter: sys.path for /usr/local/bin/python3:
/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python35.zip
/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5
/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/plat-darwin
/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/lib-dynload
/usr/local/lib/python3.5/site-packages

SublimeLinter: annotations activated: <builtin> 
reloading settings Packages/User/SublimeLinter.sublime-settings
SublimeLinter: annotations activated: <builtin> 
Package Control: Skipping automatic upgrade, last run at 2016-06-13 11:26:54, next run at 2016-06-13 12:26:54 or after
SublimeLinter: find_python(version=None, script='flake8', module=None) 
SublimeLinter: find_python: default python = /usr/local/bin/python 
SublimeLinter: find_python: available version = {'minor': 7, 'major': 2} 
SublimeLinter: find_python: 'flake8' path = /usr/local/bin/flake8 
SublimeLinter: find_python: <= ('/usr/local/bin/python', '/usr/local/bin/flake8', 2, 7) 
SublimeLinter: flake8 version query: /usr/local/bin/python /usr/local/bin/flake8 --version 
SublimeLinter: WARNING: no flake8 version could be extracted from:
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 7, in <module>
    from flake8.main import main
ImportError: No module named flake8.main

EmilStenstrom · 2016-06-13T09:28:12Z

I have python 2.7 as default (installed via homebrew) and Python 3.4 in paralell. I have flake installed inside a virtualenv running Python 3.4.

kaste · 2016-06-13T09:52:18Z

You sure have some linter config as well. ;-)

Esp. you could have something in paths and python_paths

kaste · 2016-06-13T10:06:57Z

Could you try

diff --git a/linter.py b/linter.py
index 29bdb0c..d21b5e7 100644
--- a/linter.py
+++ b/linter.py
@@ -19,7 +19,7 @@ class Flake8(PythonLinter):
     """Provides an interface to the flake8 python module/script."""

     syntax = 'python'
-    cmd = ('flake8@python', '*', '-')
+    cmd = ('flake8', '*', '-')
     version_args = '--version'
     version_re = r'^(?P<version>\d+\.\d+\.\d+)'
     version_requirement = '>= 2.2.2'

EmilStenstrom · 2016-06-13T10:46:33Z

I'll try, but I've never modified a plugin file before. I'm on Mac OSX. Installed plugin through Package Control. Where can I find the linter.py file?

FichteFoll · 2016-06-13T11:07:13Z

Use https://packagecontrol.io/packages/PackageResourceViewer to access and modify a resource file.

Gr1N · 2016-06-13T11:12:17Z

@kaste your fix works perfect.

SublimeLinter: flake8 version query: /usr/local/bin/flake8 --version 
SublimeLinter: flake8 version: 2.5.4 
SublimeLinter: flake8: (>= 2.2.2) satisfied by 2.5.4 
SublimeLinter: flake8 activated: /usr/local/bin/flake8

EmilStenstrom · 2016-06-13T11:26:55Z

Thanks @FichteFoll, that was easier than I thought.

Modifying the file works great for me too. I guess my case is slightly different since I start sublime from inside a virtualenv where flake8 is installed. Non the less, it works! Thanks.

kaste · 2016-06-14T22:18:21Z

Some more feedback on my hotfix? I remember I had this in the first version of this PR, but I don't know anymore why I decided against it.

Hotfix for SublimeLinter#38 Fixes SublimeLinter#40

kaste · 2016-06-15T13:09:37Z

Follow up #41.

[Hotfix] Completely remove invariant python handling for this plugin

kaste reviewed May 10, 2016
View reviewed changes

This was referenced May 10, 2016

show-code option is not working #35

Closed

invalid syntax on async keyword #33

Closed

SublimeLinter is calling Flake8 with the system python instead of the Virtualenv #34

Closed

kaste mentioned this pull request May 10, 2016

Adding custom flake8 args in Python3 #36

Closed

numberoverzero reviewed May 14, 2016
View reviewed changes

kaste force-pushed the patch-1 branch 2 times, most recently from 53fa4ac to a33474c Compare May 14, 2016 11:29

kaste reviewed May 14, 2016
View reviewed changes

Remove cruft

7d3d6b3

* Never use builtin python 3.3 for linting Fixes SublimeLinter#33 * Make `show-code` actually work Fixes SublimeLinter#35 * Add option `executable` so you can point explicitly to a flake8 installation in case SL's which isn't smart enough (which it isn't on Windows)

kaste force-pushed the patch-1 branch from a33474c to 7d3d6b3 Compare May 25, 2016 11:04

groteworld merged commit ac40521 into SublimeLinter:master Jun 12, 2016

kaste mentioned this pull request Jun 14, 2016

Plugin tries to run flake8 in python2 instead of python3 #40

Closed

kaste added a commit to kaste/SublimeLinter-flake8 that referenced this pull request Jun 15, 2016

Completely remove invariant python handling for this plugin

67ea70b

Hotfix for SublimeLinter#38 Fixes SublimeLinter#40

kaste mentioned this pull request Jun 15, 2016

[Hotfix] Completely remove invariant python handling for this plugin #41

Merged

groteworld referenced this pull request Jun 15, 2016

Merge pull request #41 from kaste/hotfix-for-#38

bfe2088

[Hotfix] Completely remove invariant python handling for this plugin

sjahl mentioned this pull request Oct 17, 2016

Linter always uses /usr/local/bin/flake8 #43

Closed

kaste mentioned this pull request Dec 15, 2016

Allow different python versions and enable virtualenv. #51

Merged

kaste deleted the patch-1 branch July 18, 2022 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove cruft #38

Remove cruft #38

kaste commented May 10, 2016 •

edited

Loading

kaste May 10, 2016

kaste commented May 10, 2016

kaste commented May 10, 2016

Gr1N commented May 10, 2016

kaste commented May 10, 2016

jacobsvante commented May 11, 2016

numberoverzero May 14, 2016

kaste May 14, 2016

kaste commented May 14, 2016

kaste May 14, 2016

kaste commented May 14, 2016

jacobsvante commented May 17, 2016

FichteFoll commented May 25, 2016 •

edited

Loading

kaste commented May 25, 2016

kaste commented May 25, 2016

Gr1N commented May 25, 2016 •

edited

Loading

FichteFoll commented Jun 12, 2016 •

edited

Loading

EmilStenstrom commented Jun 12, 2016

FichteFoll commented Jun 12, 2016

Gr1N commented Jun 13, 2016 •

edited

Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 13, 2016

kaste commented Jun 13, 2016 •

edited

Loading

Gr1N commented Jun 13, 2016 •

edited

Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 13, 2016 •

edited

Loading

kaste commented Jun 13, 2016 •

edited

Loading

EmilStenstrom commented Jun 13, 2016

FichteFoll commented Jun 13, 2016

Gr1N commented Jun 13, 2016 •

edited

Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 14, 2016

kaste commented Jun 15, 2016

Remove cruft #38

Remove cruft #38

Conversation

kaste commented May 10, 2016 • edited Loading

kaste May 10, 2016

Choose a reason for hiding this comment

kaste commented May 10, 2016

kaste commented May 10, 2016

Gr1N commented May 10, 2016

kaste commented May 10, 2016

jacobsvante commented May 11, 2016

numberoverzero May 14, 2016

Choose a reason for hiding this comment

kaste May 14, 2016

Choose a reason for hiding this comment

kaste commented May 14, 2016

kaste May 14, 2016

Choose a reason for hiding this comment

kaste commented May 14, 2016

jacobsvante commented May 17, 2016

FichteFoll commented May 25, 2016 • edited Loading

kaste commented May 25, 2016

kaste commented May 25, 2016

Gr1N commented May 25, 2016 • edited Loading

FichteFoll commented Jun 12, 2016 • edited Loading

EmilStenstrom commented Jun 12, 2016

FichteFoll commented Jun 12, 2016

Gr1N commented Jun 13, 2016 • edited Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 13, 2016

kaste commented Jun 13, 2016 • edited Loading

Gr1N commented Jun 13, 2016 • edited Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 13, 2016 • edited Loading

kaste commented Jun 13, 2016 • edited Loading

EmilStenstrom commented Jun 13, 2016

FichteFoll commented Jun 13, 2016

Gr1N commented Jun 13, 2016 • edited Loading

EmilStenstrom commented Jun 13, 2016

kaste commented Jun 14, 2016

kaste commented Jun 15, 2016

kaste commented May 10, 2016 •

edited

Loading

FichteFoll commented May 25, 2016 •

edited

Loading

Gr1N commented May 25, 2016 •

edited

Loading

FichteFoll commented Jun 12, 2016 •

edited

Loading

Gr1N commented Jun 13, 2016 •

edited

Loading

kaste commented Jun 13, 2016 •

edited

Loading

Gr1N commented Jun 13, 2016 •

edited

Loading

kaste commented Jun 13, 2016 •

edited

Loading

kaste commented Jun 13, 2016 •

edited

Loading

Gr1N commented Jun 13, 2016 •

edited

Loading