Do not capture 'filename' #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JoyceBabu |
|
I’m 👌🏻 with the idea, but let’s rename the capture group in a way that doesn’t look like a typo (or just not name the group I guess) and add a comment. |
kaste
force-pushed
the
kaste-patch-2
branch
2 times, most recently
from
de8ca23 to
0d29861
Compare
phpmd resolves all paths to 'real' paths and uses such 'real' paths in the reports. Since we cannot map such a 'real' path back to a 'user' path, we MUST not capture these filename. Fixes #21
|
Okay? |
|
Excellent. @JoyceBabu agree? |
|
The linter error in #21 is fixed, after merging this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpmd resolves all paths to 'real' paths and uses such 'real' paths in the reports.
Since we cannot map such a 'real' path back to a 'user' path, we MUST not capture these filename. (We basically need a 1-1 mapping from a view filename to a reported filename.)
Fixes #21
Fixes SublimeLinter/SublimeLinter#1589