Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL-1590: Update bidwon and bidtimeout pixels #28

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

JeremiePat
Copy link

Description of change

Update sublimeAdapter to version 0.7.1: We need more data in the pixels we send to better qualified our win.

How to test

See : https://github.com/SublimeSkinz/Emilbus/pull/3086 to understand how to use sskz_publishers to test the prebid.js build

Each time we win a bid, checkout the bidwon pixels, it should have some new data: device, ver and timeout
The same data should be send in case of a bidtimeout

JIRA Ticket

https://sublimeskinz.atlassian.net/browse/DL-1590

@JeremiePat JeremiePat added the enhancement New feature or request label Mar 12, 2021
Copy link

@o3LL o3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part le petit ; de rien du tout, ça me semble good!

modules/sublimeBidAdapter.js Outdated Show resolved Hide resolved
@JeremiePat JeremiePat force-pushed the DL-1590/update-bidwon-bidtimeout-pixels branch from c7de09e to d5d2709 Compare March 15, 2021 15:25
@JeremiePat JeremiePat merged commit 3fd81bf into sublime-adapter Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants