Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DL-1812: Add stub advertiser domains #30

Merged
merged 4 commits into from
Jun 2, 2021
Merged

DL-1812: Add stub advertiser domains #30

merged 4 commits into from
Jun 2, 2021

Conversation

o3LL
Copy link

@o3LL o3LL commented Jun 2, 2021

How to test

# Install the recommended version of NodeJs
nvm install

# Install dep
npm i

# Run tests
npm run test

@o3LL o3LL self-assigned this Jun 2, 2021
@o3LL o3LL changed the title Dl 1812/add stub advertiser domains DL-1812: Add stub advertiser domains Jun 2, 2021
fgcloutier
fgcloutier reviewed Jun 2, 2021
View reviewed changes
modules/sublimeBidAdapter.js
// We don't support advertiserDomains atm
if (response.advertiserDomains) {
// Creating a stub for Prebid.js 5.0 compliance
bidResponse.meta = Object.assign({}, bidResponse.meta, { advertiserDomains: [] });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE11 à la poubelle !
(puisque de toutes façons on ne passera pas dans cette branche...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci Babel 🤝

SublimeJeremy
SublimeJeremy approved these changes Jun 2, 2021
View reviewed changes
Copy link

@SublimeJeremy SublimeJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@o3LL o3LL merged commit d86c3ec into sublime-adapter Jun 2, 2021
@o3LL o3LL deleted the DL-1812/Add-stub-advertiserDomains branch June 2, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgcloutier fgcloutier fgcloutier approved these changes

@SublimeJeremy SublimeJeremy SublimeJeremy approved these changes

@mdarse mdarse mdarse approved these changes

@JeremiePat JeremiePat Awaiting requested review from JeremiePat

Assignees

@o3LL o3LL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@o3LL @mdarse @SublimeJeremy @fgcloutier