"create adjacent and carry" doesn't carry #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new pane is created, the cursor ends up there as well. This is why the carry command does not work. Pulling it instead solves this.
rchl
approved these changes
Jul 2, 2021
|
LGTM. Thanks! |
rchl
changed the title
create_pane_with_file creates and then pulls the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161
When the new pane is created, the cursor ends up there as well. This is why the carry command does not work. I'm not sure when this feature broke or if it behaves differently in ST4 than it did in ST3.
Since the newly created pane becomes active, the file can be pulled from the opposite direction instead.
It can be tested without a code change by adding this keybind:
{ "keys": ["ctrl+space", "ctrl+u"], "command": "chain", "args": { "commands": [ {"command": "create_pane", "args": {"direction": "up"}}, {"command": "pull_file_from_pane", "args": {"direction": "down"}} ] } },I also tested it locally by uninstalling the package, using my own branch and then using the original keybind to
create_pane_with_file.