settings: Make quick edit phantoms disableable (#353)

Author: UltraInstinct05

Package/PackageDev.sublime-settings

@@ -26,6 +26,10 @@
     // Each theme containing one of the list's strings is hidden.
     "settings.exclude_theme_patterns": [],
 
+    // Whether to show the edit settings pencil icon. Close & reopen the 
+    // settings file for this to take effect.
+    "settings.show_quick_edit_icon": true,
+
     // Whether or not to keep the scope suffix in the suggested test scopes
     // i.e. if the base scope is text.html.markdown
     // then suggest meta.example.markdown (true) vs meta.example (false).

plugins/settings/__init__.py

@@ -145,7 +145,7 @@ def __init__(self, view):
             logger.error("Not a Sublime Text Settings or Project file: %r", filepath)
 
         self.phantom_set = sublime.PhantomSet(self.view, "sublime-settings-edit")
-        if self._is_base_settings_view():
+        if self._is_base_settings_view() and get_setting("settings.show_quick_edit_icon"):
             self.build_phantoms()
 
     def __del__(self):
@@ -156,7 +156,7 @@ def __del__(self):
     def on_modified_async(self):
         """Sublime Text modified event handler to update linting."""
         self.do_linting()
-        if self._is_base_settings_view():
+        if self._is_base_settings_view() and get_setting("settings.show_quick_edit_icon"):
             # This may only occur for unpacked packages
             self.build_phantoms()