Add a way to enable/disable the settings quick edit (pencil) icon. #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an additional setting `settings.enable_quick_edit_icon`, that will allow the user to control whether they want to see & use PD's quick edit settings icon. Miscellaneous commit notes: --------------------------- 1. It took quite some time to understand where the setting `edit_settings_view` was being applied to base setting view, since PD itself did not seem to do it. After some digging, it's actually being applied by `Default/settings.py`. Just for posterity.
keith-hall
approved these changes
Sep 21, 2021
FichteFoll
requested changes
Oct 7, 2021
FichteFoll
approved these changes
Oct 8, 2021
FichteFoll
changed the title
FichteFoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional setting
settings.show_quick_edit_icon, that will allow the user to control whether they want to see & use PD's quick edit settings icon.It took quite some time to understand where the setting
edit_settings_viewwas being applied to base setting view, since PD itself did not seem to do it. After some digging, it's actually being applied byDefault/settings.py. Just for posterity.Fixes #334