Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect syntax highlighting for sublime-theme #274

Closed
absop opened this issue Dec 19, 2019 · 2 comments · Fixed by #281
Closed

Incorrect syntax highlighting for sublime-theme #274

absop opened this issue Dec 19, 2019 · 2 comments · Fixed by #281
Labels
enhancement
Milestone
3.2.16

Comments

@absop
Copy link

absop commented Dec 19, 2019

When I open the source file of the Material-theme-lighter theme, large part of the view was highlighted in RED means illegal syntax. But the there works well.
@FichteFoll
Copy link
Member

Please include the or a minimal sample file for reproduction and a screenshot.

@FichteFoll
Copy link
Member

FichteFoll commented Dec 19, 2019 •
edited
Loading

Okay, I found out where it breaks. "layer0.texture": [255, 255, 255, 255],

According to the docs, texture keys only accept string paths to PNG files, so this is actually an error in the theme. I may try to have it fail in a more forgiving way, but I may also consider it not worth it.

https://www.sublimetext.com/docs/3/themes.html

deathaxe added a commit to deathaxe/PackageDev that referenced this issue Feb 22, 2020
@deathaxe
Themes: Fix invalid list/mapping highlighting
3f19748 
Fixes SublimeText#274

Scope unexpected value types more gracefully to avoid breaking syntax
highlighting of the following content.
@deathaxe deathaxe mentioned this issue Feb 22, 2020
Merged
deathaxe added a commit to deathaxe/PackageDev that referenced this issue Feb 22, 2020
@deathaxe
Themes: Fix invalid list/mapping highlighting
bba3c35 
Fixes SublimeText#274

Scope unexpected value types more gracefully to avoid breaking syntax
highlighting of the following content.
FichteFoll pushed a commit that referenced this issue Feb 26, 2020
@deathaxe @FichteFoll
Themes: Fix invalid list/mapping highlighting
5c8d45b 
Fixes #274

Scope unexpected value types more gracefully to avoid breaking syntax
highlighting of the following content.
@FichteFoll FichteFoll added this to the 3.2.16 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.2.16
Development

Successfully merging a pull request may close this issue.

Themes: Fix invalid list/mapping highlighting deathaxe/PackageDev
2 participants
@FichteFoll @absop