Settings: Fix duplicated value completions #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btw. nice changes done in the recent commits. To continue completing each others ideas, this PR proposes some fixes for regressions introduced by 30983c7 which cause:
(default)
marks for list values (e.g.: "indent_guide_options").The method
_completions_from_comment()
needs to do default marking in order to prevent_completions_from_default()
to add the same value.The
format_completion_item()
function needs to handlelist
type default values when settingis_default
.Force
_completions_from_default()
to mark values added from thedefault
list by passingis_default=True
to theformat_completion_item()
. It's just an optimization to avoid thevalue in default
check.