Settings: Fix completion values #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause was that text manipulation was reordered in a wrong way: JSON-encoded string was converted to snippet-field-content-encoded string first, but then it was treated as a simply JSON-encoded string again. Namely, stripping curly brackets away _after_ encoding them as \\} broke cursor things in a weird ways. Used pretty printing just because it looks better. But it required extra whitespace stripping: both outside and inside stripped brackets/braces. Also changed variable name from `encoded` to `content` in fmt, so they can never be accidentally reordered again. Fixes SublimeText#347
|
ping @FichteFoll |
|
Sorry for the delay. I took a very brief look but haven't found the time to finish up a release where this would then be included (I already added the milestone of the next version). I don't want to make promises, but I have some free time on Thursday where I hope to finally get to PD again. |
|
take your time :) |
|
Thanks, works really well and pretty-printing is a good idea, especially since we already insert the content in a new line. (Sorry again for the delay.) Edit: re-added commit message via bfa509b. |
FichteFoll
changed the title
FichteFoll
pushed a commit
that referenced
this pull request
Feb 26, 2022
The root cause was that text manipulation was reordered in a wrong way: JSON-encoded string was converted to snippet-field-content-encoded string first, but then it was treated as a simply JSON-encoded string again. Namely, stripping curly brackets away _after_ encoding them as \\} broke cursor things in a weird ways. Used pretty printing just because it looks better. But it required extra whitespace stripping: both outside and inside stripped brackets/braces. Also changed variable name from `encoded` to `content` in fmt, so they can never be accidentally reordered again. Fixes #347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause was that text manipulation was reordered in a wrong way:
JSON-encoded string was converted to snippet-field-content-encoded
string first, but then it was treated as a simply JSON-encoded string
again. Namely, stripping curly brackets away after encoding them
as \} broke cursor things in a weird ways.
Used pretty printing just because it looks better. But it required extra
whitespace stripping: both outside and inside stripped
brackets/braces.
Also changed variable name from
encodedtocontentin fmt, so theycan never be accidentally reordered again.
Fixes #347