Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AnalysisTech unlock message & sound #372

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Fix AnalysisTech unlock message & sound #372

merged 6 commits into from
Jun 2, 2023

Conversation

vlyon
Copy link
Contributor

@vlyon vlyon commented May 29, 2023

Changes made in this pull request

  • Fixed spelling in DefaultUnlockMessage
  • Added DefaultPickupMessage, which is used when RequiredForUnlock == TechType.None
  • Fixed missing unlockSound

@LeeTwentyThree
Copy link
Member

Sorry for hijacking this PR, I never realized how messed up this gadget file is. I got carried away with writing assorted changes instead of leaving written reviews.

LeeTwentyThree
LeeTwentyThree approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now. We will have to check again after we hear back from UWE.

@LeeTwentyThree LeeTwentyThree merged commit 75eeef6 into SubnauticaModding:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeTwentyThree LeeTwentyThree LeeTwentyThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlyon @LeeTwentyThree