Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PDA item sorting capabilities #403

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

vlyon
Copy link
Contributor

@vlyon vlyon commented Jun 10, 2023

Changes made in this pull request

  • Ability to append after or insert before a target item when adding to a PDA category
  • Ability to insert before all entries when adding to a PDA category

Breaking changes

  • CraftDataHandler.AddToGroup(TechGroup, TechCategory, TechType, TechType) overload was modified.

Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions/nitpicks

Nautilus/Assets/Gadgets/GadgetExtensions.cs Outdated Show resolved Hide resolved
Nautilus/Assets/Gadgets/GadgetExtensions.cs Outdated Show resolved Hide resolved
Nautilus/Assets/Gadgets/ScanningGadget.cs Show resolved Hide resolved
Nautilus/Assets/Gadgets/ScanningGadget.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/CraftDataHandler.cs Outdated Show resolved Hide resolved
Nautilus/Patchers/CraftDataPatcher.cs Show resolved Hide resolved
Nautilus/Patchers/CraftDataPatcher.cs Show resolved Hide resolved
@vlyon vlyon force-pushed the better-pda-sorting branch from a4a3eff to 257f6ea Compare June 16, 2023 16:00
@vlyon vlyon force-pushed the better-pda-sorting branch from 257f6ea to 667ceef Compare June 16, 2023 16:23
@LeeTwentyThree LeeTwentyThree added the Status: 👀 Waiting for review Assigned person says its done.... but is it really? label Jun 16, 2023
Applied suggestions to improve docs.
@LeeTwentyThree LeeTwentyThree added Status: Revision Needed and removed Status: 👀 Waiting for review Assigned person says its done.... but is it really? labels Jun 16, 2023
@LeeTwentyThree
Copy link
Member

Ready for merge as soon as all of the above requests are resolved.

@LeeTwentyThree
Copy link
Member

Did some testing and everything seems to work as intended. Great improvement 👍

Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see issues in the future with mod compatibility, but it's fine.

@LeeTwentyThree LeeTwentyThree merged commit 181d16d into SubnauticaModding:master Jun 19, 2023
@vlyon vlyon deleted the better-pda-sorting branch June 19, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants