Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark packages as development dependencies #461

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Mark packages as development dependencies #461

merged 1 commit into from
Sep 7, 2023

Conversation

tinyhoot
Copy link
Contributor

@tinyhoot tinyhoot commented Sep 7, 2023

Changes made in this pull request

  • Set BepInEx.AssemblyPublicizer, BepInEx.PluginInfoProps and PolySharp as development dependencies, as they are not necessarily needed by downstream projects looking to install the NuGet package.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tinyhoot
Copy link
Contributor Author

tinyhoot commented Sep 7, 2023

I have read the CLA Document and I hereby sign the CLA.

@tinyhoot
Copy link
Contributor Author

tinyhoot commented Sep 7, 2023

recheck

github-actions bot added a commit that referenced this pull request Sep 7, 2023
@github-actions
@tinyhoot has signed the CLA in #461
fdfa05b
Metious
Metious approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Metious Metious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for contributing!

I have tested your changes and the built NuGet package for release indeed does not have those packages as dependencies.
image

This was definitely needed, appreciate you looking into it :)

@Metious Metious merged commit e544e00 into SubnauticaModding:master Sep 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Metious Metious Metious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinyhoot @Metious