Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fake constructables being moved to GlobalRoot #2254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tornac1234
Copy link
Collaborator

Fake constructables being the ones you encounter in the world, placed on the ground only for the player to deconstruct them and gain some materials from it

@tornac1234 tornac1234 added this to the 1.8 milestone Jan 12, 2025
@tornac1234 tornac1234 added the Area: spawning Related to spawning and/or terrain label Jan 12, 2025
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CW

@dartasen
Copy link
Member

dartasen commented Jan 18, 2025

Tested InGame with Ninja

  • go to wreck13
  • deconstruct the table and the big box
  • go to wreck 8
  • go back to wreck13, the table and big box will respawn and will break sync because it's not registered on the server

@tornac1234 tornac1234 force-pushed the fix-fake-constructables-in-global-root branch from 92e349b to 168a9ef Compare February 8, 2025 21:22
@tornac1234
Copy link
Collaborator Author

Tested InGame with Ninja

* go to wreck13

* deconstruct the table and the big box

* go to wreck 8

* go back to wreck13, the table and big box will respawn and will break sync because it's not registered on the server

Seems weird to me because with this all the latest work merged (especially #2263), none of those are deconstructables. I am now unable to find constructable stuff in the wilderness.

Though in this PR, I changed the "constructable -> globalroot" behaviour's target from "all entities" to "only buildings" which is the accurate way of it, which should be reviewed as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: spawning Related to spawning and/or terrain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants