Merge pull request rubocop#11950 from koic/fix_a_false_positive_for_l…

…ayout_redundant_line_break [Fix rubocop#11949] Fix a false positive for `Layout/RedundantLineBreak`
Subramanya-Murugesan · Jun 14, 2023 · 144b578 · 144b578
2 parents ae82e46 + 820ec28
commit 144b578
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/changelog/fix_a_false_positive_for_layout_redundant_line_break.md b/changelog/fix_a_false_positive_for_layout_redundant_line_break.md
@@ -0,0 +1 @@
+* [#11949](https://github.com/rubocop/rubocop/issues/11949): Fix a false positive for `Layout/RedundantLineBreak` when using a line broken string. ([@koic][])
diff --git a/lib/rubocop/cop/layout/redundant_line_break.rb b/lib/rubocop/cop/layout/redundant_line_break.rb
@@ -99,7 +99,7 @@ def single_line_block_chain_enabled?
         def suitable_as_single_line?(node)
           !comment_within?(node) &&
             node.each_descendant(:if, :case, :kwbegin, :def).none? &&
-            node.each_descendant(:dstr, :str).none?(&:heredoc?) &&
+            node.each_descendant(:dstr, :str).none? { |n| n.heredoc? || n.value.include?("\n") } &&
             node.each_descendant(:begin).none? { |b| !b.single_line? }
         end
 

diff --git a/spec/rubocop/cop/layout/redundant_line_break_spec.rb b/spec/rubocop/cop/layout/redundant_line_break_spec.rb
@@ -341,6 +341,16 @@ def resolve_inheritance_from_gems(hash)
               .baz
           RUBY
         end
+
+        it 'does not register an offense with a line broken string argument' do
+          expect_no_offenses(<<~RUBY)
+            foo('
+              xyz
+            ')
+              .bar
+              .baz
+          RUBY
+        end
       end
     end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#11949](https://github.com/rubocop/rubocop/issues/11949): Fix a false positive for `Layout/RedundantLineBreak` when using a line broken string. ([@koic][])
-Original file line number
+Diff line change
@@ Expand Up / @@ -341,6 +341,16 @@ def resolve_inheritance_from_gems(hash) @@
                   .baz
               RUBY
             end
+            it 'does not register an offense with a line broken string argument' do
+              expect_no_offenses(<<~RUBY)
+                foo('
+                  xyz
+                ')
+                  .bar
+                  .baz
+              RUBY
+            end
           end
         end
@@ Expand Down @@