Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): update path for server.spec.strategy.type #1001

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(charts): update path for server.spec.strategy.type #1001

merged 2 commits into from
Sep 17, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 17, 2024 •
edited
Loading

Description

Fixes FL-1733

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes
fix(charts): update path for server.spec.strategy.type
04af1d4 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 17, 2024 08:59
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 17, 2024 08:59
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Sep 17, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@linear Linear
Copy link

linear bot commented Sep 17, 2024

FL-1733 During a flux reconciliation, the server and the registry pods need to be scale down/up

thbcmlowk
thbcmlowk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to look at it. Chart version update and changelog entry are missing, but otherwise LG(very)TM!

@guilhem-barthes
chore: bump chart version
de7e20c 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes merged commit 288005b into main Sep 17, 2024
10 checks passed
@guilhem-barthes guilhem-barthes deleted the fix/update-strategy-format branch September 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhem-barthes @Owlfred @SdgJlbl @thbcmlowk