Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: save image timeout 2 #1011

Merged
merged 5 commits into from
Oct 11, 2024
Merged

fix: save image timeout 2 #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b84d512
fix: add build timeout during task initialisation
guilhem-barthes Oct 11, 2024
6f60a75
chore: increase default value for `builder.saveImageTimeoutSeconds`
guilhem-barthes Oct 11, 2024
f4a50b1
fix: increase default value for `builder.saveImageTimeoutSeconds`
guilhem-barthes Oct 11, 2024
4bfb302
fix: add variable to builder
guilhem-barthes Oct 11, 2024
4c0eb08
chore: update chart changelog
guilhem-barthes Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/substra-backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Changelog

<!-- towncrier release notes start -->
## [26.14.1] - 2024-10-11

# Fixed

Save image timeout not set correctly

## [26.14.0] - 2024-10-09

# Added
Expand Down
2 changes: 1 addition & 1 deletion charts/substra-backend/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: substra-backend
home: https://github.com/Substra
version: 26.14.0
version: 26.14.1
appVersion: 0.48.0
kubeVersion: '>= 1.19.0-0'
description: Main package for Substra
Expand Down
2 changes: 1 addition & 1 deletion charts/substra-backend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ See [UPGRADE.md](https://github.com/Substra/substra-backend/blob/main/charts/sub
| `builder.nodeSelector` | Node labels for pod assignment | `{}` |
| `builder.tolerations` | Toleration labels for pod assignment | `[]` |
| `builder.affinity` | Affinity settings for pod assignment, ignored if `DataSampleStorageInServerMedia` is `true` | `{}` |
| `builder.saveImageTimeoutSeconds` | Amount of seconds before restarting the image save as a blob | `60` |
| `builder.saveImageTimeoutSeconds` | Amount of seconds before restarting the image save as a blob | `180` |
| `builder.persistence.storageClass` | Specify the _StorageClass_ used to provision the volume. Or the default _StorageClass_ will be used. Set it to `-` to disable dynamic provisioning | `""` |
| `builder.persistence.size` | The size of the volume. | `10Gi` |
| `builder.rbac.create` | Create a role and service account for the builder | `true` |
Expand Down
2 changes: 2 additions & 0 deletions charts/substra-backend/templates/statefulset-builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ spec:
value: {{ toYaml .Values.builder.kanikoStartup.maxAttempts | quote }}
- name: BUILDER_KANIKO_STARTUP_PENDING_STATE_WAIT_SECONDS
value: {{ toYaml .Values.builder.kanikoStartup.checkDelay | quote }}
- name: IMAGE_SAVING_TIMEOUT_SECONDS
value: {{ .Values.builder.saveImageTimeoutSeconds | quote }}
Comment on lines +203 to +204
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed for the builder itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing, in some cases the worker was not sufficient, will retest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also confirmed on my end, LGTM

- name: IMAGE_BUILD_TIMEOUT
value: {{ toYaml .Values.builder.timeout | quote }}
ports:
Expand Down
2 changes: 1 addition & 1 deletion charts/substra-backend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ builder:
affinity: { }
## @param builder.saveImageTimeoutSeconds Amount of seconds before restarting the image save as a blob
#
saveImageTimeoutSeconds: 60
saveImageTimeoutSeconds: 180


persistence:
Expand Down
Loading