docs: add a note arguing you should generate tokens #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oleobal
force-pushed
the
docs/why-generate-tokens
branch
3 times, most recently
from
963d524 to
25304bd
Compare
SdgJlbl
reviewed
Aug 8, 2023
SdgJlbl
reviewed
Aug 8, 2023
SdgJlbl
reviewed
Aug 8, 2023
SdgJlbl
approved these changes
Aug 8, 2023
SdgJlbl
reviewed
Aug 8, 2023
|
Waiting for Substra/substra-backend#698 to merge |
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Co-authored-by: Sarah Diot-Girard <sarah.diot-girard@owkin.com> Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Co-authored-by: Sarah Diot-Girard <sarah.diot-girard@owkin.com> Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
oleobal
force-pushed
the
docs/why-generate-tokens
branch
from
f291af2 to
1fc9672
Compare
oleobal
added a commit
to Substra/substra-backend
that referenced
this pull request
Aug 17, 2023
- Solve the issue of sometimes issuing tokens that are about to expire, by just issuing an new token every time and relying on the SDK to clean them up - Add a new `server.allowImplicitLogin` option, allowing node admins to disable the option altogether in order to improve security practices. - Extend `/active-api-tokens -X DELETE` to also be able to delete `ImplicitBearerToken`, adding an `id` field to `ImplicitBearerToken` for this purpose. This is to enable users to terminate their sessions, as per security recommendations Closes FL-1067, FL-1140 Companion to Substra/substra-documentation#336 Leveraged by Substra/substra#381 Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
EazyAl
pushed a commit
to EazyAl/substra-documentation
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com> Co-authored-by: Sarah Diot-Girard <sarah.diot-girard@owkin.com> Signed-off-by: EazyAl <ali.imran@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note at the top of the token generation howto, explaining why you should, what you should do if you don't, and that administrators can disable it.
I'd like to add a link to the proper helm chart value in that last item, but I don't really know what to link to (the value is
server.allowImplicitLogin.Companion PR to Substra/substra-backend#698
Similar to #335 and Substra/substra#378