Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge predict and test tasks #376

Merged
merged 15 commits into from
Feb 27, 2024
Merged

feat: merge predict and test tasks #376

merged 15 commits into from
Feb 27, 2024

Conversation

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ThibaultFy ThibaultFy force-pushed the feat/merge-predict-test branch 2 times, most recently from 31a48d8 to cc9a0e5 Compare October 12, 2023 15:10
@ThibaultFy
Copy link
Member Author

/e2e --tests doc --refs substrafl=feat/merge-predict-test

@Owlfred
Copy link

Owlfred commented Oct 12, 2023

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@ThibaultFy ThibaultFy requested a review from SdgJlbl October 31, 2023 15:07
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo left, otherwise LGTM
Thanks for the PR 👍

@ThibaultFy ThibaultFy force-pushed the feat/merge-predict-test branch from 8df809e to cec911e Compare December 12, 2023 16:31
@ThibaultFy ThibaultFy force-pushed the feat/merge-predict-test branch 2 times, most recently from b5a3e78 to 3af0d75 Compare February 26, 2024 14:43
ThibaultFy and others added 13 commits February 26, 2024 16:43
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy force-pushed the feat/merge-predict-test branch from 3af0d75 to 79004f7 Compare February 26, 2024 15:43
@ThibaultFy ThibaultFy merged commit bec5bd7 into main Feb 27, 2024
7 checks passed
@ThibaultFy ThibaultFy deleted the feat/merge-predict-test branch February 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants