New techniques merge #63
Conversation
| public boolean canSeeCell(Cell other) { | ||
| return Grid.visibleCellsSet[index].contains(other); | ||
| } | ||
|
|
There was a problem hiding this comment.
canSeeCell() unless in blind mode?
Isn't seesCell() more descriptive?
There was a problem hiding this comment.
It was supposed to be a yes or no question ... May something was lost there
There was a problem hiding this comment.
BTW, seesCell() works too!!
| @Override | ||
| public String getnotMaxTechnique3() { | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
This is all my doing. I can't blame anybody else :) ... The idea is to have more control on what to generate
Command line should be easier to control. GUI currently has Drop down menu with a general theme of generated puzzle. More can be done if there were drop menus / input field for each sub category (rating, technique to include , …)
There was a problem hiding this comment.
My solution would be TABLE with one row per (sub-)technique and many columns - rating, rating rules, names, short/long names, html description template, java class and constuctor parameters, etc, etc. even including nested tables if needed.
Then you should program GUI just what column to display.
There was a problem hiding this comment.
I uploaded a generateDiff.ods file which I can use to create the JTABLE or TABLE when I have time
|
Good job @SudokuMonster ! |
|
I don't think releasing an imperfect version is a bad thing especially when I haven't announced it. The clunky techniques can be disabled from the command line. When we have a better improved version I'll release another improved one. The time frame of improving what we have now is unknown, so I thought to get a release out of the way 1st |
|
I finished with my queued changes and committed them to master. |
The clunky 2 strong links and 3 strong links techniques are now added to master. They will require an overhaul to improve performance as discussed partly in #60