Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of work with getField selectors (if we stick with the current methodology) #163

Closed
plocket opened this issue Mar 5, 2021 · 1 comment

Comments

@plocket
Copy link
Collaborator

plocket commented Mar 5, 2021

I think we can avoid all these repetition in selector clauses by setting a variable, e.g., base_64_var_or_index to either a variable name or an index variable. We have the ability to detect whether a given argument var_name is a variable name or an index name. So once we know which one it is, we can just use that.

Originally posted by @niharikasingh in #160 (comment)

@plocket
Copy link
Collaborator Author

plocket commented Jun 12, 2021

Great suggestion. We're now switching to getPageData(), so this is no longer necessary.

@plocket plocket closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant