Re #158, temp fix for simple index_var detection #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vars might be set out of order.
niharikasingh
approved these changes
Mar 5, 2021
| @@ -402,17 +438,29 @@ module.exports = { | |||
| let noneOfTheAboveCheckbox = fieldset.querySelector('input.danota-checkbox'); | |||
There was a problem hiding this comment.
Make clear somehow that only one of base64_id_of_first_choice and base64_id_of_index will exist. The way we check for both made it seem to me like both of these might be true somehow. Same for base64_var_name and base64_index.
There was a problem hiding this comment.
This would be negated by using the second comment to clarify the code. Thanks!
| @@ -380,9 +390,35 @@ module.exports = { | |||
| // 'none of the above' checkbox showif??? | |||
| `input[name="${ name_attr_B }"]`, // checkbox | |||
| `input[name="${ name_attr_R }"]`, // checkbox alt | |||
|
|
|||
| // simple index var case as described above | |||
| `button[name="${ base64_index }"][value="${ choice_name }"]`, // button | |||
There was a problem hiding this comment.
I think we can avoid all these repetition in selector clauses by setting a variable, e.g., base_64_var_or_index to either a variable name or an index variable. We have the ability to detect whether a given argument var_name is a variable name or an index name. So once we know which one it is, we can just use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vars might be set out of order. Addresses #158, but does not close it. This will let some tests work under some circumstances. This test shows the result (passes).