Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cucumber to a dependency instead of a peer dependency #396

Closed
plocket opened this issue Dec 5, 2021 · 2 comments · Fixed by #400
Closed

Move cucumber to a dependency instead of a peer dependency #396

plocket opened this issue Dec 5, 2021 · 2 comments · Fixed by #400
Assignees
Labels
good first issue Doesn't need much context. Good for project newcomers.
Milestone

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 5, 2021

Also, probably remove devDependency of cucumber.

@plocket plocket added the good first issue Doesn't need much context. Good for project newcomers. label Dec 6, 2021
@plocket plocket self-assigned this Dec 7, 2021
@plocket
Copy link
Collaborator Author

plocket commented Dec 7, 2021

Connected to SuffolkLITLab/docassemble-ALKilnSetup#163

@plocket
Copy link
Collaborator Author

plocket commented Dec 7, 2021

As a discussion, this covers why we're deciding against having puppeteer and cucumber as peer dependencies.

This framework is mostly made for people who aren't familiar with git/github/standard development in general and are focused on developing docassemble interviews. We don't expect them to develop their own puppeteer code or cucumber steps. If users do choose to do those things, then they should use their own versions of those libraries so they aren't dependent on us to keep up to date on their own versions of those libraries. Their work and our work doesn't need to stay aligned.

In the future, we might make better hooks for people to customize our code (for example, with custom fields). At that point we might discuss how to keep versions aligned.

It might be good to add documentation, at some point, for how people can develop on their own and/or diverge from our code.

@plocket plocket added this to the v4 milestone Dec 12, 2021
plocket added a commit that referenced this issue Dec 16, 2021
Close #396 for v3, move cucumber to plain dependencies (not peer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Doesn't need much context. Good for project newcomers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants