-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't take screenshot of signature pages #511
Can't take screenshot of signature pages #511
Comments
Note; documented in SuffolkLITLab/docassemble-AssemblyLine-documentation#282 |
Wasn't closed. Not sure why I did that. It was just documented. [Not sure how to get rid of the link to the PR, dangit.] |
I think we can deal with this by listening to a window |
Alternatively, when taking a screenshot we can try to determine if it's a signature page and, if so, don't use the 'full screen' option. |
Also one plain language improvement that didn't need to be in here. Closes #511
Also one plain language improvement that didn't need to be in here. Closes #511
Adjusted suffolk documentation to remove warnings about this bug. |
It causes an error because taking a screenshot erases the signature. This is technically a bug, but not one that's urgent so I'm going to avoid derailing us by leaving off that label. We can't think of a reason anyone other than us would want to take a screenshot of the signature page. It's going to be documented with SuffolkLITLab/docassemble-AssemblyLine-documentation#212.
More details:
Docassemble currently handles signatures in-house, but hasn't accounted for the page zooming in and out, which clears the drawing in the canvas. When kiln takes a screenshot, it uses the "full page" feature of puppeteer, which seems to zoom out on the page to get the whole thing in the viewport. That causes the signature to be erased.
A potential solution for the future is to take screenshots differently on signature pages [- don't take a full page screenshot]. That might be problematic if developers are trying to find out things about the page that are off-screen, though. An upstream fix is probably necessary, so we might focus on that instead. The code is near the beginning of app.js.
The text was updated successfully, but these errors were encountered: