Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't take screenshot of signature pages #511

Closed
plocket opened this issue Feb 11, 2022 · 6 comments · Fixed by SuffolkLITLab/docassemble-AssemblyLine-documentation#282 or #652
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@plocket
Copy link
Collaborator

plocket commented Feb 11, 2022

It causes an error because taking a screenshot erases the signature. This is technically a bug, but not one that's urgent so I'm going to avoid derailing us by leaving off that label. We can't think of a reason anyone other than us would want to take a screenshot of the signature page. It's going to be documented with SuffolkLITLab/docassemble-AssemblyLine-documentation#212.

More details:

Docassemble currently handles signatures in-house, but hasn't accounted for the page zooming in and out, which clears the drawing in the canvas. When kiln takes a screenshot, it uses the "full page" feature of puppeteer, which seems to zoom out on the page to get the whole thing in the viewport. That causes the signature to be erased.

A potential solution for the future is to take screenshots differently on signature pages [- don't take a full page screenshot]. That might be problematic if developers are trying to find out things about the page that are off-screen, though. An upstream fix is probably necessary, so we might focus on that instead. The code is near the beginning of app.js.

@plocket plocket added the enhancement New feature or request label Feb 11, 2022
@plocket plocket added the documentation Improvements or additions to documentation label Apr 16, 2022
@BryceStevenWilley
Copy link
Collaborator

@plocket
Copy link
Collaborator Author

plocket commented Sep 1, 2022

@plocket plocket closed this as completed Sep 1, 2022
@plocket
Copy link
Collaborator Author

plocket commented Sep 8, 2022

Wasn't closed. Not sure why I did that. It was just documented. [Not sure how to get rid of the link to the PR, dangit.]

@plocket plocket reopened this Sep 8, 2022
@plocket plocket removed the documentation Improvements or additions to documentation label Sep 8, 2022
@plocket plocket removed their assignment Sep 9, 2022
@plocket
Copy link
Collaborator Author

plocket commented Jan 27, 2023

I think we can deal with this by listening to a window resize or orientationchange, then re-drawing after the event.

@plocket
Copy link
Collaborator Author

plocket commented Feb 12, 2023

Alternatively, when taking a screenshot we can try to determine if it's a signature page and, if so, don't use the 'full screen' option.

@plocket plocket added the bug Something isn't working label Feb 12, 2023
@plocket plocket self-assigned this Feb 12, 2023
plocket added a commit that referenced this issue Feb 12, 2023
Also one plain language improvement that didn't need to be in here.
Closes #511
plocket added a commit that referenced this issue Feb 15, 2023
Also one plain language improvement that didn't need to be in here.
Closes #511
@plocket
Copy link
Collaborator Author

plocket commented Feb 15, 2023

Adjusted suffolk documentation to remove warnings about this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants