Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust artifact folder and interview loading to allow devs to test list of interviews from the server #600

Closed
2 of 3 tasks
plocket opened this issue Aug 31, 2022 · 1 comment · Fixed by #602 or #603
Closed
2 of 3 tasks

Adjust artifact folder and interview loading to allow devs to test list of interviews from the server #600

plocket opened this issue Aug 31, 2022 · 1 comment · Fixed by #602 or #603
Assignees
@plocket
Labels
priority A combination of urgency and impact

Comments

@plocket
Copy link
Collaborator

plocket commented Aug 31, 2022 •
edited
Loading

Related to, but separate from #599, as this is needed even if we're not handling the rest of the mess in this repository.

Two things need to be adjusted:

  • Testing the list of interviews from the server should avoid loading any package onto the server, so we'll need to create artifact folder even when setup.js isn't run. Artifact folder creation needs to be moved to BeforeAll() in steps.js.
  • The interview load step needs to be able to go to an arbitrary address. The list of interviews have a different kind of link to access them and it doesn't match our current pattern.

Edit:

  • The runtime_config.json needs to be created even when only the artifact folder is created. It is currently created only when saving the project name.
@plocket plocket added the priority A combination of urgency and impact label Aug 31, 2022
@plocket plocket self-assigned this Aug 31, 2022
plocket added a commit that referenced this issue Aug 31, 2022
@plocket
Close #600. Allow devs to test list of interviews on their server.
f18ced5
@plocket plocket mentioned this issue Aug 31, 2022
Merged
plocket added a commit that referenced this issue Sep 1, 2022
@plocket
Close #600. Allow devs to test list of interviews on their server. (#602
f002a09 
)

* Close #600. Allow devs to test list of interviews on their server.
* Update test and don't print possible secrets
* Get more specific with url str test and CHANGELOG, but need to
document that arbitrary urls won't be secret in the report -
they'll be printed as is. We can't detect what's secret in there.
* Update text of arbitrary url tests
* Remove possibly secret server address from report
@plocket
Copy link
Collaborator Author

plocket commented Sep 1, 2022

The runtime_config.json needs to be created even when only the artifact folder is created. It is currently created only when saving the project name.

@plocket plocket reopened this Sep 1, 2022
@plocket plocket mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plocket plocket

Labels
priority A combination of urgency and impact
Projects
None yet
Milestone
No milestone
1 participant
@plocket