Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure SERVER_RELOAD_TIMEOUT_SECONDS is being used as seconds and possibly alias #606

Closed
plocket opened this issue Sep 2, 2022 · 1 comment · Fixed by #608
Closed
Labels
bug Something isn't working

Comments

@plocket
Copy link
Collaborator

plocket commented Sep 2, 2022

I think it's currently assumed to be MS despite the name.

Edit:
Also, the server setup timeout is called MAX_SECONDS_FOR_SETUP, so maybe this one should have an alias called something like MAX_SECONDS_FOR_SERVER_RELOAD.

@plocket plocket added the bug Something isn't working label Sep 2, 2022
@plocket plocket changed the title Make sure SERVER_RELOAD_TIMEOUT_SECONDS is being used as seconds Make sure SERVER_RELOAD_TIMEOUT_SECONDS is being used as seconds and possibly rename Sep 2, 2022
@plocket plocket changed the title Make sure SERVER_RELOAD_TIMEOUT_SECONDS is being used as seconds and possibly rename Make sure SERVER_RELOAD_TIMEOUT_SECONDS is being used as seconds and possibly alias Sep 2, 2022
@BryceStevenWilley
Copy link
Collaborator

Offending lines (where we get the value is seconds and set to the variables that is assumed to be in miliseconds):

ALKiln/lib/scope.js

Lines 533 to 534 in f002a09

// Should we require the expected value to be seconds instead of ms?
ms_till_server_timeout = parseInt( session_vars.get_server_reload_timeout() );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants