You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently that Step always expects navigation. [We've opted not to making a breaking change, but instead tweak the Steps a bit.]
What I really want to do is change that Step to not navigate and make a new step that ends with "to navigate" or "to go to another/the next page".
This would be a breaking change, but I want to check with folks whether they use that step yet at all. If not, we can possibly change that step so it doesn't navigate without changing major versions. Otherwise we have to make a new Step with extra text that I don't appreciate.
This would be a good opportunity to move "waiting to navigate" into its own function in scope.js. Right now it's in the AfterStep function.
check with all the users we know whether they're currently using that Step to navigate.
The text was updated successfully, but these errors were encountered:
Maybe we can make this sentence seem more normal by making things "worse". We use two "new" sentences instead of one:
I tap ...element and stay on the same page
I tap ...element and go to a new page
Under the hood, the second one doesn't do anything different than the default behavior and if you leave them both off then the default behavior still happens. Old tests will still pass and these two Steps will be together in the documentation, so they're awkward, but they'll make sense in context with each other.
regular .click() supposedly only works with input elements,
according to stackoverflow, and it seems to be working. We'll see
if inconsistent behavior comes back. I can't find it mentioned
online in the context it used to be mentioned.
Close#834
* Add Step to click without navigating. Use puppeteer click again as
regular .click() supposedly only works with input elements,
according to stackoverflow, and it seems to be working. We'll see
if inconsistent behavior comes back. I can't find it mentioned
online in the context it used to be mentioned.
Close#834
* Publish version our action can use
* Update changelog
Currently that Step always expects navigation. [We've opted not to making a breaking change, but instead tweak the Steps a bit.]
What I really want to do is change that Step to not navigate and make a new step that ends with "to navigate" or "to go to another/the next page".This would be a breaking change, but I want to check with folks whether they use that step yet at all. If not, we can possibly change that step so it doesn't navigate without changing major versions. Otherwise we have to make a new Step with extra text that I don't appreciate.This would be a good opportunity to move "waiting to navigate" into its own function in scope.js. Right now it's in the
AfterStep
function.check with all the users we know whether they're currently using that Step to navigate.The text was updated successfully, but these errors were encountered: