Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step: I tap the element using selector (without navigating) #834

Closed
1 task done
plocket opened this issue Dec 14, 2023 · 1 comment · Fixed by #838
Closed
1 task done

Step: I tap the element using selector (without navigating) #834

plocket opened this issue Dec 14, 2023 · 1 comment · Fixed by #838
Assignees
Labels
enhancement New feature or request

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 14, 2023

Currently that Step always expects navigation. [We've opted not to making a breaking change, but instead tweak the Steps a bit.]

What I really want to do is change that Step to not navigate and make a new step that ends with "to navigate" or "to go to another/the next page".

This would be a breaking change, but I want to check with folks whether they use that step yet at all. If not, we can possibly change that step so it doesn't navigate without changing major versions. Otherwise we have to make a new Step with extra text that I don't appreciate.

This would be a good opportunity to move "waiting to navigate" into its own function in scope.js. Right now it's in the AfterStep function.

  • check with all the users we know whether they're currently using that Step to navigate.
@plocket plocket added enhancement New feature or request question Further information is requested deep dive labels Dec 14, 2023
@plocket plocket self-assigned this Dec 17, 2023
@plocket plocket removed question Further information is requested deep dive labels Dec 17, 2023
@plocket
Copy link
Collaborator Author

plocket commented Dec 18, 2023

Maybe we can make this sentence seem more normal by making things "worse". We use two "new" sentences instead of one:

  1. I tap ...element and stay on the same page
  2. I tap ...element and go to a new page

Under the hood, the second one doesn't do anything different than the default behavior and if you leave them both off then the default behavior still happens. Old tests will still pass and these two Steps will be together in the documentation, so they're awkward, but they'll make sense in context with each other.

plocket added a commit that referenced this issue Dec 18, 2023
regular .click() supposedly only works with input elements,
according to stackoverflow, and it seems to be working. We'll see
if inconsistent behavior comes back. I can't find it mentioned
online in the context it used to be mentioned.

Close #834
plocket added a commit that referenced this issue Dec 18, 2023
* Add Step to click without navigating. Use puppeteer click again as

regular .click() supposedly only works with input elements,
according to stackoverflow, and it seems to be working. We'll see
if inconsistent behavior comes back. I can't find it mentioned
online in the context it used to be mentioned.

Close #834

* Publish version our action can use

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant