Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe action triggers #869

Closed
plocket opened this issue Apr 16, 2024 · 1 comment · Fixed by #872
Closed

De-dupe action triggers #869

plocket opened this issue Apr 16, 2024 · 1 comment · Fixed by #872
Assignees
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.

Comments

@plocket
Copy link
Collaborator

plocket commented Apr 16, 2024

Implement this code:

jobs:
  job_name:
    if: (github.event_name != 'pull_request' && ! github.event.pull_request.head.repo.fork) || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork)

https://github.com/IHaskell/IHaskell/blob/60a750f5b038a17717609d8a40be0fafd69e1c35/.github/workflows/stack.yml#L37

It could make a good example [for our users]. Is there a reason to test the event happening at the same time? There are plenty of non-pr times when we push, so we should see plenty of both triggers.

@plocket plocket added enhancement New feature or request reopen We won't be taking care of this any time soon. labels Apr 16, 2024
@plocket plocket self-assigned this Apr 23, 2024
@plocket
Copy link
Collaborator Author

plocket commented Apr 23, 2024

I misrepresented this a bit. To be clear, the only time the PR workflows will run is if the PR is from a fork. We'll have to keep an eye out for when we should test fork PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant