Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check log codes better #920

Closed
plocket opened this issue Jul 5, 2024 · 0 comments · Fixed by #923
Closed

Check log codes better #920

plocket opened this issue Jul 5, 2024 · 0 comments · Fixed by #923
Assignees

Comments

@plocket
Copy link
Collaborator

plocket commented Jul 5, 2024

Plan for https://github.com/SuffolkLITLab/ALKiln/blob/v5/tests/log_codes/check_codes.sh:

  • For every log code, count how many times it appears in the codebase
  • By default, expect one of each code
  • That can be overridden somehow to allow 2, 3, n appearances of a log code
  • Still have a similar kind of output, just to keep it clean

This is tricky to develop locally because bash is different in different OSs. GitHub uses ubuntu. This is an ubuntu environment on replit in which I am experimenting. That already has the current files in it. I'm not sure how to make a generic ubuntu environment there, but it did replicate GitHub behavior. Feel free to fork!

@plocket plocket self-assigned this Jul 11, 2024
plocket added a commit that referenced this issue Jul 14, 2024
Improve log codes checker, close #920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant