Enter time input correctly #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default text doesn't enter time inputs correct for a few reasons: * The text input doesn't expected you to type ":", spaces, or the "M" in "AM" or "PM". The space specifically seems to mess up inputs. * You need to key press "Enter" after entering the time, otherwise moving focus will erase the current input. This change filters the time value given to remove ":", " ", and "M", and also adds an Enter keypress to make sure the value is entered correctly.
plocket
approved these changes
Jul 14, 2023
|
Reminder to myself to edit the CHANGELOG when publishing. |
#729 is made! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default text doesn't enter time inputs correct for a few reasons:
This change filters the time value given to remove ":", " ", and "M", and also adds an Enter keypress to make sure the value is entered correctly.
I added a new YML, because the input needs to be required for us to actually test it, and I can't make it required with 5 different tests all trying to use
all_tests.ymlfor the same thing, so I split it out instead.