Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updates for dependency security #727

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

BryceStevenWilley
Copy link
Collaborator

@BryceStevenWilley BryceStevenWilley commented Jul 14, 2023

  • cucumber 8.6.0 -> 9.3.0
    • NOTABLE: cucumber has dropped support for Node 12 and 17 from v8 to v9.
  • mocha 9.2.0 -> 9.2.2
  • qs 6.10.2 -> 6.10.3
  • puppeteer 20.7.2 -> 20.8.2
  • minimatch 3.0.4 -> 3.0.5 (was 3.0.4 in many dependencies, patch shouldn't break them)

Should address the following, fairly serious, security issues:

If this passes, I'll merge. Some of those issues are bad, so I've made a patch for v4, pushing now.

* cucumber 8.6.0 -> 9.3.0
  * NOTABLE: cucumber has dropped support for Node 12 and 17 from v8 to v9.
* mocha 9.2.0 -> 9.2.2
* qs 6.10.2 -> 6.10.3
* puppeteer 20.7.2 -> 20.8.2
* minimatch 3.0.4 -> 3.0.5 (was 3.0.4 in many dependencies, patch shouldn't break them)

Should address the following, fairly serious, security issues:

* Sandbox escape vuln: GHSA-g644-9gfx-q4q4
* Prototype pollution: GHSA-hrpp-h998-j3pp
* Regex DoS (less critical IMO): GHSA-j8xg-fqg3-53r7
* Another Regex DoS: GHSA-f8q6-p94x-37v3
BryceStevenWilley added a commit that referenced this pull request Jul 14, 2023
* mocha 9.2.0 -> 9.2.2
* qs 6.10.2 -> 6.10.3
* minimatch 3.0.4 -> 3.0.5

See #727 for more details.
Copy link
Collaborator

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BryceStevenWilley BryceStevenWilley merged commit 12dc240 into v5 Jul 14, 2023
@BryceStevenWilley BryceStevenWilley deleted the dependency_security branch July 14, 2023 18:35
BryceStevenWilley added a commit that referenced this pull request Jul 14, 2023
* mocha 9.2.0 -> 9.2.2
* qs 6.10.2 -> 6.10.3
* minimatch 3.0.4 -> 3.0.5

See #727 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants