Pdfjs #774
Merged
Pdfjs #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also notes where I found a particular fix for loading the PDF
2 tasks
|
Ready for review, addressed all of the comments, and made slight cleanups to the |
plocket
requested changes
Oct 14, 2023
Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
Based on the existing accessibility code for checking all of the steps before now. Continues either if the PDF to compare couldn't be found (a developer error), or if the PDFs are different, since it doesn't affect interview progression. Also corrected a missed `scope.addToReport -> reports.addToReport` refactor.
plocket
approved these changes
Oct 14, 2023
|
Add to the changelog if you have a mo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to compare PDFs! It's currently one step,
I expect the baseline PDF "something-in-sources.pdf" and the new PDF "downloaded.pdf" to be the same, but happy to add more, depending on what we think would be useful for folks.Making this a draft to make sure the API is as we want it.
In this PR, I have:
Links to any solved or related issues
Fix #25.
Any manual testing I have done to ensure my PR is working
Just added the automated tests.